From: Patrick McHardy <kaber@trash.net>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
William Boughton <bill@boughton.de>,
netdev@vger.kernel.org, stephen.hemminger@vyatta.com
Subject: Re: [Oops] fib_trie with ip route add throw since 2.6.25
Date: Mon, 07 Jul 2008 22:29:04 +0200 [thread overview]
Message-ID: <48727C90.6060604@trash.net> (raw)
In-Reply-To: <20080707202558.GF28029@solarflare.com>
Ben Hutchings wrote:
> Stephen Hemminger wrote:
> [...]
>> Agreed, a little more explanation would be good
>> * return values?? fn_trie_lookup is same as fn_hash_lookup
>> * check_leaf use return value of fn_trie_lookup so it can warpout without conditional
>> * this needs some comments.
>
> It does, doesn't it? I still don't know what the return values mean, but
> when William found this I stared at the diff and looked at the callers
> until I spotted what the functional change was. :-)
They are suppposed to mirror the fib_semantic_match return values
if I recall correctly.
next prev parent reply other threads:[~2008-07-07 20:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 18:41 [Oops] fib_trie with ip route add throw since 2.6.25 William Boughton
2008-07-07 19:57 ` Ben Hutchings
2008-07-07 20:12 ` Stephen Hemminger
2008-07-07 20:25 ` Ben Hutchings
2008-07-07 20:29 ` Patrick McHardy [this message]
2008-07-08 22:52 ` Stephen Hemminger
2008-07-09 4:55 ` William Boughton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48727C90.6060604@trash.net \
--to=kaber@trash.net \
--cc=bhutchings@solarflare.com \
--cc=bill@boughton.de \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen.hemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).