From: Patrick McHardy <kaber@trash.net>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Nicolas Pitre <nico@cam.org>,
Dale Farnsworth <dale@farnsworth.org>,
Ashish Karkare <akarkare@marvell.com>,
Jesper Dangaard Brouer <jdb@comx.dk>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand
Date: Mon, 07 Jul 2008 23:01:18 +0200 [thread overview]
Message-ID: <4872841E.1030609@trash.net> (raw)
In-Reply-To: <20080707205646.GB12997@xi.wantstofly.org>
Lennert Buytenhek wrote:
> When inserting a vlan tag into an skb by hand (in the case the
> target network device hardware does not support inserting a vlan
> tag by passing it in via the TX descriptor), making a copy of the
> skb to be modified by calling skb_copy() is overkill, since
> skb_copy() will needlessly linearize the skb, copying of all of
> the fragmented data around, and checksumming the paket in software
> even if the hardware is perfectly capable of doing that by itself.
>
> For this case, pskb_copy() does exactly what is needed and no more,
> so use that instead.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
This looks fine to me.
next prev parent reply other threads:[~2008-07-07 21:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 20:56 [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand Lennert Buytenhek
2008-07-07 21:01 ` Patrick McHardy [this message]
2008-07-07 21:07 ` Lennert Buytenhek
2008-07-07 21:15 ` Patrick McHardy
2008-07-08 16:24 ` Patrick McHardy
2008-07-08 17:41 ` Patrick McHardy
2008-07-08 18:52 ` Lennert Buytenhek
2008-07-08 18:50 ` Patrick McHardy
2008-07-08 19:33 ` Lennert Buytenhek
2008-07-08 20:15 ` Patrick McHardy
2008-07-08 22:02 ` David Miller
2008-07-08 22:18 ` Patrick McHardy
2008-07-08 22:37 ` David Miller
2008-07-08 22:10 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4872841E.1030609@trash.net \
--to=kaber@trash.net \
--cc=akarkare@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=jdb@comx.dk \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).