From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: buytenh@wantstofly.org, nico@cam.org, dale@farnsworth.org,
akarkare@marvell.com, jdb@comx.dk, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand
Date: Wed, 09 Jul 2008 00:18:33 +0200 [thread overview]
Message-ID: <4873E7B9.2020304@trash.net> (raw)
In-Reply-To: <20080708.150257.41516850.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Tue, 08 Jul 2008 22:15:55 +0200
>
>
>> Great, thanks. The patch applies cleanly with or without the VLAN
>> packet socket patches I sent today, so Dave can either just apply
>> it together with your mv643xx_eth patch or I'll include it when
>> sending the next VLAN update.
>>
>
> Patrick, want me to stuff this one into net-2.6?
>
> BTW, there is a typo in the commit message, you say
> "skb_cow_header()" which doesn't exist, you mean "skb_cow_head()".
> But you got it right in the code :)
>
I would feel better putting it in net-next-2.6.git. The code
currently doesn't handle shared skbs and it does look unnecessary.
But if we actually get one it will BUG in pskb_expand_head().
next prev parent reply other threads:[~2008-07-08 22:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 20:56 [PATCH 1/2][RFC] vlan: use pskb_copy() when inserting a vlan tag by hand Lennert Buytenhek
2008-07-07 21:01 ` Patrick McHardy
2008-07-07 21:07 ` Lennert Buytenhek
2008-07-07 21:15 ` Patrick McHardy
2008-07-08 16:24 ` Patrick McHardy
2008-07-08 17:41 ` Patrick McHardy
2008-07-08 18:52 ` Lennert Buytenhek
2008-07-08 18:50 ` Patrick McHardy
2008-07-08 19:33 ` Lennert Buytenhek
2008-07-08 20:15 ` Patrick McHardy
2008-07-08 22:02 ` David Miller
2008-07-08 22:18 ` Patrick McHardy [this message]
2008-07-08 22:37 ` David Miller
2008-07-08 22:10 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4873E7B9.2020304@trash.net \
--to=kaber@trash.net \
--cc=akarkare@marvell.com \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=davem@davemloft.net \
--cc=jdb@comx.dk \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).