netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mario Limonciello <mario_limonciello@dell.com>
To: Kasper Sandberg <lkml@metanurb.dk>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
	Francois Romieu <romieu@fr.zoreil.com>,
	Michael Grollman <mgrollman@nscus.com>,
	netdev@vger.kernel.org, akpm@linux-foundation.org,
	linux-pci@vger.kernel.org
Subject: Re: 8169 Intermittent ifup Failure Issue With RTL8102E Chipset in Intel's New D945GCLF Atom Board (Not the Initial Modprobe Crash, Another Problem)
Date: Mon, 14 Jul 2008 16:00:39 -0500	[thread overview]
Message-ID: <487BBE77.7050702@dell.com> (raw)
In-Reply-To: <1216068344.23392.19.camel@localhost>

[-- Attachment #1: Type: text/plain, Size: 7210 bytes --]

Kasper:

If I was to guess (I didn't actually work out which one yours identifies
as), most likely your NIC isn't caught in my check for MAC_VER_13 or
MAC_VER_16, but Francois's patch has:


-	dprintk("Set MAC Reg C+CR Offset 0x82h = 0x01h\n");
-	RTL_W8(0x82, 0x01);
+	if (tp->mac_version <= RTL_GIGA_MAC_VER_06) {
+		dprintk("Set MAC Reg C+CR Offset 0x82h = 0x01h\n");
+		RTL_W8(0x82, 0x01);
+	}

Which I've got indirectly but checking for 13 & 16.

Regards

Kasper Sandberg wrote:
> On Mon, 2008-07-14 at 15:00 -0500, Mario Limonciello wrote:
>   
>> Kasper:
>>
>> Interesting that it failed for you though.  I was able to run through a
>> script of 200x rmmod/modprobe without any trouble when that patch was
>> applied.
>>     
>
> Well are you sure it actually catches my nics?
>
> i have 8111c:
>
> 05:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
> RTL8111/8168B PCI Express Gigabit Ethernet controller [10ec:8168] (rev
> 02)
>         Subsystem: Giga-byte Technology Unknown device [1458:e000]
>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0, Cache Line Size: 32 bytes
>         Interrupt: pin A routed to IRQ 376
>         Region 0: I/O ports at c000 [size=256]
>         Region 2: Memory at e9010000 (64-bit, prefetchable) [size=4K]
>         Region 4: Memory at e9000000 (64-bit, prefetchable) [size=64K]
>         [virtual] Expansion ROM at e9020000 [disabled] [size=64K]
>         Capabilities: [40] Power Management version 3
>                 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1
> +,D2+,D3hot+,D3cold+)
>                 Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>         Capabilities: [50] Message Signalled Interrupts: Mask- 64bit+
> Queue=0/1 Enable+
>                 Address: 00000000fee0f00c  Data: 416e
>         Capabilities: [70] Express (v1) Endpoint, MSI 01
>                 DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s
> <512ns, L1 <8us
>                         ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
>                 DevCtl: Report errors: Correctable- Non-Fatal- Fatal-
> Unsupported-
>                         RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>                         MaxPayload 128 bytes, MaxReadReq 4096 bytes
>                 DevSta: CorrErr+ UncorrErr- FatalErr- UnsuppReq+ AuxPwr+
> TransPend-
>                 LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1,
> Latency L0 <512ns, L1 <64us
>                         ClockPM+ Suprise- LLActRep- BwNot-
>                 LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- Retrain-
> CommClk-
>                         ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
>                 LnkSta: Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+
> DLActive- BWMgmt- ABWMgmt-
>         Capabilities: [b0] MSI-X: Enable- Mask- TabSize=2
>                 Vector table: BAR=4 offset=00000000
>                 PBA: BAR=4 offset=00000800
>         Capabilities: [d0] Vital Product Data <?>
>         Capabilities: [100] Advanced Error Reporting <?>
>         Capabilities: [140] Virtual Channel <?>
>         Capabilities: [160] Device Serial Number 00-00-00-00-00-00-00-00
>         Kernel driver in use: r8169
>         Kernel modules: r8169
> 00: ec 10 68 81 07 04 10 00 02 00 00 02 08 00 00 00
> 10: 01 c0 00 00 00 00 00 00 0c 00 01 e9 00 00 00 00
> 20: 0c 00 00 e9 00 00 00 00 00 00 00 00 58 14 00 e0
> 30: 00 00 00 00 40 00 00 00 00 00 00 00 0a 01 00 00
>
> 06:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
> RTL8111/8168B PCI Express Gigabit Ethernet controller [10ec:8168] (rev
> 02)
>         Subsystem: Giga-byte Technology Unknown device [1458:e000]
>         Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B- DisINTx+
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0, Cache Line Size: 32 bytes
>         Interrupt: pin A routed to IRQ 375
>         Region 0: I/O ports at d000 [size=256]
>         Region 2: Memory at e9110000 (64-bit, prefetchable) [size=4K]
>         Region 4: Memory at e9100000 (64-bit, prefetchable) [size=64K]
>         [virtual] Expansion ROM at e9120000 [disabled] [size=64K]
>         Capabilities: [40] Power Management version 3
>                 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=375mA PME(D0+,D1
> +,D2+,D3hot+,D3cold+)
>                 Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>         Capabilities: [50] Message Signalled Interrupts: Mask- 64bit+
> Queue=0/1 Enable+
>                 Address: 00000000fee0f00c  Data: 4176
>         Capabilities: [70] Express (v1) Endpoint, MSI 01
>                 DevCap: MaxPayload 256 bytes, PhantFunc 0, Latency L0s
> <512ns, L1 <8us
>                         ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset-
>                 DevCtl: Report errors: Correctable- Non-Fatal- Fatal-
> Unsupported-
>                         RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>                         MaxPayload 128 bytes, MaxReadReq 512 bytes
>                 DevSta: CorrErr+ UncorrErr- FatalErr- UnsuppReq+ AuxPwr+
> TransPend-
>                 LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1,
> Latency L0 <512ns, L1 <64us
>                         ClockPM+ Suprise- LLActRep- BwNot-
>                 LnkCtl: ASPM Disabled; RCB 64 bytes Disabled- Retrain-
> CommClk-
>                         ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
>                 LnkSta: Speed 2.5GT/s, Width x1, TrErr- Train- SlotClk+
> DLActive- BWMgmt- ABWMgmt-
>         Capabilities: [b0] MSI-X: Enable- Mask- TabSize=2
>                 Vector table: BAR=4 offset=00000000
>                 PBA: BAR=4 offset=00000800
>         Capabilities: [d0] Vital Product Data <?>
>         Capabilities: [100] Advanced Error Reporting <?>
>         Capabilities: [140] Virtual Channel <?>
>         Capabilities: [160] Device Serial Number 00-00-00-00-00-00-00-00
>         Kernel driver in use: r8169
>         Kernel modules: r8169
> 00: ec 10 68 81 07 04 10 00 02 00 00 02 08 00 00 00
> 10: 01 d0 00 00 00 00 00 00 0c 00 11 e9 00 00 00 00
> 20: 0c 00 10 e9 00 00 00 00 00 00 00 00 58 14 00 e0
> 30: 00 00 00 00 40 00 00 00 00 00 00 00 0b 01 00 00
>
>
> Either way, the patchset from Francois seems to fix it, With this in
> mind, do we actually know exactly what causes it?
>
>   
>> Regards
>>
>> Rolf Eike Beer wrote:
>>     
>>> Kasper Sandberg wrote:
>>>   
>>>
>>> Is there any chance this helps with the famous 8101 problems, e.g. 
>>> http://bugzilla.kernel.org/show_bug.cgi?id=6807 ?
>>>
>>>   
>>>
>>> There is a typo in the description of 91ba1a976c214766b5ee8c6d17086903c10f6405 
>>> (serie should be series I think).
>>>
>>> Greetings,
>>>
>>> Eike
>>>   
>>>       
>
>   

-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

  reply	other threads:[~2008-07-14 21:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4861800B.90703@nscus.com>
2008-06-25 21:31 ` 8169 Intermittent ifup Failure Issue With RTL8102E Chipset in Intel's New D945GCLF Atom Board (Not the Initial Modprobe Crash, Another Problem) Francois Romieu
2008-06-26 21:08   ` Michael Grollman
2008-06-26 21:59     ` Francois Romieu
2008-06-26 22:27       ` Michael Grollman
2008-06-27  2:35       ` Matthew Wilcox
2008-06-27  2:58         ` mgrollman
2008-06-27  3:25           ` Mario_Limonciello
2008-06-27  4:44             ` Michael Grollman
2008-07-07 12:53       ` Kasper Sandberg
2008-07-07 15:15         ` Mario Limonciello
2008-07-09 17:05           ` Michael Grollman
2008-07-09 17:31             ` Mario Limonciello
2008-07-09 23:31               ` Michael Grollman
2008-07-11 13:35           ` Kasper Sandberg
2008-07-11 15:26             ` Mario Limonciello
2008-07-14 16:21               ` Kasper Sandberg
2008-07-14 19:52                 ` Rolf Eike Beer
2008-07-14 20:00                   ` Mario Limonciello
2008-07-14 20:45                     ` Kasper Sandberg
2008-07-14 21:00                       ` Mario Limonciello [this message]
2008-07-15 18:56                         ` Francois Romieu
2008-07-16 15:03                           ` Kasper Sandberg
2008-07-15 18:58                   ` Francois Romieu
2008-09-22 17:20                 ` Michael Grollman
2008-06-24 23:27 Michael Grollman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=487BBE77.7050702@dell.com \
    --to=mario_limonciello@dell.com \
    --cc=akpm@linux-foundation.org \
    --cc=eike-kernel@sf-tec.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=lkml@metanurb.dk \
    --cc=mgrollman@nscus.com \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).