From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: David Howells <dhowells@redhat.com>,
akpm@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div()
Date: Tue, 15 Jul 2008 14:10:41 +0200 [thread overview]
Message-ID: <487C93C1.4030305@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0807151400160.13215@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Tuesday 2008-07-15 13:43, Patrick McHardy wrote:
>
>> David Howells wrote:
>>> Fix netfilter xt_time's time_mt()'s use of do_div() on an s64 by using
>>> div_s64() instead.
>>>
>>> This was introduced by patch ee4411a1b1e0b679c99686629b5eab5a072ce49f.
>> Alternatively we could use an u64 for the time. Jan, any preferences?
>
> ktime_t and ktime_to_ns operate on signed quantities. I do not think we
> should be interpreting it as unsigned.
OK, I've applied David's patch. Thanks.
prev parent reply other threads:[~2008-07-15 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 14:02 [PATCH] Fix netfilter xt_time's time_mt()'s use of do_div() David Howells
2008-07-15 11:43 ` Patrick McHardy
2008-07-15 12:08 ` Jan Engelhardt
2008-07-15 12:10 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487C93C1.4030305@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).