From: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
Liran Liss <liranl@mellanox.co.il>,
tziporet@mellanox.co.il, Roland Dreier <rdreier@cisco.com>
Subject: Re: [PATCH RFC 03/10] mlx4_en: net_device implementation
Date: Tue, 15 Jul 2008 18:01:03 +0300 [thread overview]
Message-ID: <487CBBAF.9030704@mellanox.co.il> (raw)
In-Reply-To: <20080714194228.GU19302@solarflare.com>
Ben Hutchings wrote:
>
> This is already under RTNL; why do you need your own semaphore?
> (And why are you using semaphores, not mutexes?)
We approach the device/port state from many functions, not all protected by the
RTNL lock.
You are right about the mutex, it needs to be changed.
Yevgeny
prev parent reply other threads:[~2008-07-15 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-14 14:41 [PATCH RFC 03/10] mlx4_en: net_device implementation Yevgeny Petrilin
2008-07-14 19:42 ` Ben Hutchings
2008-07-15 15:01 ` Yevgeny Petrilin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487CBBAF.9030704@mellanox.co.il \
--to=yevgenyp@mellanox.co.il \
--cc=bhutchings@solarflare.com \
--cc=jeff@garzik.org \
--cc=liranl@mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=tziporet@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).