From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATC] sctp: various fixes
Date: Mon, 21 Jul 2008 09:12:21 -0400 [thread overview]
Message-ID: <48848B35.6050702@hp.com> (raw)
In-Reply-To: <20080719.224047.228019059.davem@davemloft.net>
David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Fri, 18 Jul 2008 23:08:33 -0700 (PDT)
>
>> From: Vlad Yasevich <vladislav.yasevich@hp.com>
>> Date: Sat, 19 Jul 2008 00:26:45 -0400
>>
>>> This is a bunch of SCTP fixes that have accumlated over the past week or
>>> so.
>> All applied, thanks Vlad.
>
> Vlad, I had to add the following fix to the tree in order
> to unbreak the build when CONFIG_HIGHMEM is enabled.
>
ahh... since tcp isn't a module, it didn't trigger that.
Thanks Dave. I didn't think about turning highmem off..
-vlad
> highmem: Export totalhigh_pages.
>
> Hash et al. sizing code in SCTP wants to make the
> calculation totalram_pages - totalhigh_pages, just
> like TCP. But this requires an export for the
> CONFIG_HIGHMEM case to work.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 7da4a7b..e16e152 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -40,6 +40,7 @@
> #ifdef CONFIG_HIGHMEM
>
> unsigned long totalhigh_pages __read_mostly;
> +EXPORT_SYMBOL(totalhigh_pages);
>
> unsigned int nr_free_highpages (void)
> {
>
next prev parent reply other threads:[~2008-07-21 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 4:26 [PATC] sctp: various fixes Vlad Yasevich
2008-07-19 4:26 ` [PATCH 1/7] sctp: Don't abort initialization when CONFIG_PROC_FS=n Vlad Yasevich
2008-07-19 4:26 ` [PATCH 2/7] sctp: Prevent uninitialized memory access Vlad Yasevich
2008-07-19 4:26 ` [PATCH 3/7] sctp: Support ipv6only AF_INET6 sockets Vlad Yasevich
2008-07-19 4:26 ` [PATCH 4/7] sctp: Do not leak memory on multiple listen() calls Vlad Yasevich
2008-07-19 4:26 ` [PATCH 5/7] sctp: Allow only 1 listening socket with SO_REUSEADDR Vlad Yasevich
2008-07-19 4:26 ` [PATCH 6/7] sctp: remove unnecessary byteshifting, calculate directly in big-endian Vlad Yasevich
2008-07-19 4:26 ` [PATCH 7/7] sctp: Update sctp global memory limit allocations Vlad Yasevich
2008-07-19 6:08 ` [PATC] sctp: various fixes David Miller
2008-07-20 5:40 ` David Miller
2008-07-21 13:12 ` Vlad Yasevich [this message]
2008-07-21 15:05 ` David Miller
2008-07-21 15:19 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48848B35.6050702@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).