netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net-2.6 patch 1/1][SCHED] remove unused variable skb in dev_deactivate_queue function
@ 2008-07-21 16:01 Daniel Lezcano
  2008-07-21 16:18 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Lezcano @ 2008-07-21 16:01 UTC (permalink / raw)
  To: David Miller; +Cc: Linux Netdev List

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: remove-unused-variable.patch --]
[-- Type: text/plain, Size: 920 bytes --]

Subject: [SCHED] remove unused variable skb in dev_deactivate_queue function
From: Daniel Lezcano <dlezcano@fr.ibm.com>

Removed unused variable 'skb' in the dev_deactivate_queue function

Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
---
 net/sched/sch_generic.c |    3 ---
 1 file changed, 3 deletions(-)

Index: net-2.6/net/sched/sch_generic.c
===================================================================
--- net-2.6.orig/net/sched/sch_generic.c
+++ net-2.6/net/sched/sch_generic.c
@@ -576,7 +576,6 @@ static void dev_deactivate_queue(struct 
 				 void *_qdisc_default)
 {
 	struct Qdisc *qdisc_default = _qdisc_default;
-	struct sk_buff *skb = NULL;
 	struct Qdisc *qdisc;
 
 	qdisc = dev_queue->qdisc;
@@ -588,8 +587,6 @@ static void dev_deactivate_queue(struct 
 
 		spin_unlock_bh(qdisc_lock(qdisc));
 	}
-
-	kfree_skb(skb);
 }
 
 static bool some_qdisc_is_running(struct net_device *dev, int lock)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [net-2.6 patch 1/1][SCHED] remove unused variable skb in dev_deactivate_queue function
  2008-07-21 16:01 [net-2.6 patch 1/1][SCHED] remove unused variable skb in dev_deactivate_queue function Daniel Lezcano
@ 2008-07-21 16:18 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-07-21 16:18 UTC (permalink / raw)
  To: dlezcano; +Cc: netdev

From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Mon, 21 Jul 2008 18:01:31 +0200

> [SCHED] remove unused variable skb in dev_deactivate_queue function
> 
> Removed unused variable 'skb' in the dev_deactivate_queue function
> 
> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>

Applied, thanks Daniel.

Please use "subsystem_in_lowercase: Foo bar baz." format for
commit header lines in the future.

Thanks again.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-21 16:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21 16:01 [net-2.6 patch 1/1][SCHED] remove unused variable skb in dev_deactivate_queue function Daniel Lezcano
2008-07-21 16:18 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).