From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
dev@openvz.org, xemul@openvz.org, ebiederm@xmission.com,
dlezcano@fr.ibm.com, benjamin.thery@bull.net
Subject: Re: [PATCH 20/31] netns ct: NOTRACK in netns
Date: Mon, 21 Jul 2008 19:08:43 +0200 [thread overview]
Message-ID: <4884C29B.7060107@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0807211901220.21244@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Monday 2008-07-21 18:50, Alexey Dobriyan wrote:
>
>> +++ b/net/netfilter/xt_state.c
>> @@ -30,7 +31,7 @@ state_mt(const struct sk_buff *skb, const struct net_device *in,
>> enum ip_conntrack_info ctinfo;
>> unsigned int statebit;
>>
>> - if (nf_ct_is_untracked(skb))
>> + if (nf_ct_is_untracked(dev_net(in ? in : out), skb))
>
> Does this even do the right thing? Given the forward path, where
> both in!=NULL and out!=NULL, why should it specifically be 'in'
> that is selected?
It doesn't matter, the namespace during forwaring is always
equal for the input and output devices.
prev parent reply other threads:[~2008-07-21 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 16:50 [PATCH 20/31] netns ct: NOTRACK in netns Alexey Dobriyan
2008-07-21 17:05 ` Jan Engelhardt
2008-07-21 17:08 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4884C29B.7060107@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=benjamin.thery@bull.net \
--cc=dev@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).