From: Patrick McHardy <kaber@trash.net>
To: Adrian Bunk <bunk@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: struct tpacket_auxdata userspace ABI breakage
Date: Tue, 22 Jul 2008 18:36:51 +0200 [thread overview]
Message-ID: <48860CA3.7030806@trash.net> (raw)
In-Reply-To: <20080722160844.GK14846@cs181140183.pp.htv.fi>
Adrian Bunk wrote:
> Commit 393e52e33c6c26ec7db290dab803bac1bed962d4
> (packet: deliver VLAN TCI to userspace) adds a
> member tp_vlan_tci to struct tpacket_auxdata.
>
> This changes the size of the struct, and unless I miss something
> it is an ABI change that must be reverted.
It increases the structure size under the assumption that userspace
should be able to handle this since its expected that more things
will be added over time. Existing binaries will continue to run just
fine in any case, the only potential problem is when compiling against
new headers and running on old kernels (structures will appear
undersized if userspace doesn't handle this correctly). An alternative
would a new cmsg for the VLAN TCI.
The only existing user of this (a set of patches I sent for libpcap)
handles this correctly though.
prev parent reply other threads:[~2008-07-22 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 16:08 struct tpacket_auxdata userspace ABI breakage Adrian Bunk
2008-07-22 16:36 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48860CA3.7030806@trash.net \
--to=kaber@trash.net \
--cc=bunk@kernel.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).