struct tpacket_auxdata userspace ABI breakage

struct tpacket_auxdata userspace ABI breakage

[Adrian Bunk]

Commit 393e52e33c6c26ec7db290dab803bac1bed962d4
(packet: deliver VLAN TCI to userspace) adds a
member tp_vlan_tci to struct tpacket_auxdata.

This changes the size of the struct, and unless I miss something
it is an ABI change that must be reverted.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: struct tpacket_auxdata userspace ABI breakage

[Patrick McHardy]

Adrian Bunk wrote:
> Commit 393e52e33c6c26ec7db290dab803bac1bed962d4
> (packet: deliver VLAN TCI to userspace) adds a
> member tp_vlan_tci to struct tpacket_auxdata.
> 
> This changes the size of the struct, and unless I miss something
> it is an ABI change that must be reverted.

It increases the structure size under the assumption that userspace
should be able to handle this since its expected that more things
will be added over time. Existing binaries will continue to run just
fine in any case, the only potential problem is when compiling against
new headers and running on old kernels (structures will appear
undersized if userspace doesn't handle this correctly). An alternative
would a new cmsg for the VLAN TCI.

The only existing user of this (a set of patches I sent for libpcap)
handles this correctly though.