From: Jeff Garzik <jgarzik@pobox.com>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
NETDEV <netdev@vger.kernel.org>
Subject: Re: RESEND [PATCH 2/2] de4x5: Remove developer debug feature about set/clear promisc
Date: Tue, 22 Jul 2008 16:09:32 -0400 [thread overview]
Message-ID: <48863E7C.8040302@pobox.com> (raw)
In-Reply-To: <48856C6E.5090706@cn.fujitsu.com>
Wang Chen wrote:
> IFF_PROMISC flag shouldn't be set or cleared by drivers, because
> whether device be promisc mode is decided by how many upper layer
> callers being referenced to it.
> And the promisc changing feature of de4x5 ioctl is developer debug
> feature, we can remove it now.
>
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
> Acked-by: Grant Grundler <grundler@parisc-linux.org>
applied
prev parent reply other threads:[~2008-07-22 20:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <48856C0B.7090602@cn.fujitsu.com>
2008-07-22 5:13 ` RESEND [PATCH 2/2] de4x5: Remove developer debug feature about set/clear promisc Wang Chen
2008-07-22 20:09 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48863E7C.8040302@pobox.com \
--to=jgarzik@pobox.com \
--cc=grundler@parisc-linux.org \
--cc=netdev@vger.kernel.org \
--cc=wangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).