From: Jeff Garzik <jeff@garzik.org>
To: Dhananjay Phadke <dhananjay@netxen.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RESENDv2 01/11] netxen: cleanup unused variables/functions
Date: Tue, 22 Jul 2008 18:01:21 -0400 [thread overview]
Message-ID: <488658B1.9040505@garzik.org> (raw)
In-Reply-To: <1216694650-23257-2-git-send-email-dhananjay@netxen.com>
Dhananjay Phadke wrote:
> o Reduce access to global arrays in data path.
> o Remove duplicate/unused variables, unecessary alignment constraints.
> o Use correct pci_dev instead of fallback device for consistent
> allocations.
> o Disable ethtool set_eeprom functionality for now, it was only used
> for flashing firmware.
>
> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
> ---
> drivers/net/netxen/netxen_nic.h | 19 +--
> drivers/net/netxen/netxen_nic_ethtool.c | 5 +-
> drivers/net/netxen/netxen_nic_hw.c | 270 +++++++-----------------------
> drivers/net/netxen/netxen_nic_init.c | 88 +++-------
> drivers/net/netxen/netxen_nic_main.c | 74 ++-------
> drivers/net/netxen/netxen_nic_phan_reg.h | 17 +--
> 6 files changed, 113 insertions(+), 360 deletions(-)
applied 1-11
prev parent reply other threads:[~2008-07-22 22:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 2:44 [RESENDv2 01/11] netxen: cleanup unused variables/functions Dhananjay Phadke
2008-07-22 22:01 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488658B1.9040505@garzik.org \
--to=jeff@garzik.org \
--cc=dhananjay@netxen.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).