* Fix typo in meth driver
@ 2008-07-11 21:12 Christoph Lameter
2008-07-22 23:39 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Lameter @ 2008-07-11 21:12 UTC (permalink / raw)
To: Kay Sievers; +Cc: netdev
An | in an if statement to check a bit? I think this needs to be a &.
As a result of this typo meth will always operate in promiscuous mode.
Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Index: linux-2.6/drivers/net/meth.c
===================================================================
--- linux-2.6.orig/drivers/net/meth.c 2008-07-11 16:05:00.000000000 -0500
+++ linux-2.6/drivers/net/meth.c 2008-07-11 16:05:02.000000000 -0500
@@ -287,7 +287,7 @@
/* Initial mode: 10 | Half-duplex | Accept normal packets */
priv->mac_ctrl = METH_ACCEPT_MCAST | METH_DEFAULT_IPG;
- if (dev->flags | IFF_PROMISC)
+ if (dev->flags & IFF_PROMISC)
priv->mac_ctrl |= METH_PROMISC;
mace->eth.mac_ctrl = priv->mac_ctrl;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix typo in meth driver
2008-07-11 21:12 Fix typo in meth driver Christoph Lameter
@ 2008-07-22 23:39 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-07-22 23:39 UTC (permalink / raw)
To: Christoph Lameter; +Cc: Kay Sievers, netdev
Christoph Lameter wrote:
> An | in an if statement to check a bit? I think this needs to be a &.
> As a result of this typo meth will always operate in promiscuous mode.
>
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
>
> Index: linux-2.6/drivers/net/meth.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/meth.c 2008-07-11 16:05:00.000000000 -0500
> +++ linux-2.6/drivers/net/meth.c 2008-07-11 16:05:02.000000000 -0500
> @@ -287,7 +287,7 @@
>
> /* Initial mode: 10 | Half-duplex | Accept normal packets */
> priv->mac_ctrl = METH_ACCEPT_MCAST | METH_DEFAULT_IPG;
> - if (dev->flags | IFF_PROMISC)
> + if (dev->flags & IFF_PROMISC)
> priv->mac_ctrl |= METH_PROMISC;
> mace->eth.mac_ctrl = priv->mac_ctrl;
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-07-22 23:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-11 21:12 Fix typo in meth driver Christoph Lameter
2008-07-22 23:39 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).