netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "François Valenduc" <francois.valenduc@tvcablenet.be>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	bugme-daemon@bugzilla.kernel.org, linux-wireless@vger.kernel.org,
	"John W. Linville" <linville@tuxdriver.com>,
	Linux Netdev List <netdev@vger.kernel.org>,
	Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Subject: Re: [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965
Date: Wed, 23 Jul 2008 18:25:48 +0200	[thread overview]
Message-ID: <48875B8C.2090800@trash.net> (raw)
In-Reply-To: <4887555A.30605@trash.net>

Patrick McHardy wrote:
> François Valenduc wrote:
>> Patrick McHardy a écrit :
>>>> In file included from net/mac80211/main.c:11:
>>>> include/net/mac80211.h: In function ‘IEEE80211_SKB_CB’:
>>>> include/net/mac80211.h:347: erreur: size of array ‘type name’ is 
>>>> negative
>>>
>>>
>>> I was afraid that might happen. This means skb->cb is not large
>>> enough to hold both the qdisc and the ieee80211 structs.
>>>
>>> Just for testing, changing (include/net/mac80211.h):
>>>
>>> #define IEEE80211_TX_INFO_DRIVER_DATA_SIZE \
>>>         (sizeof(((struct sk_buff *)0)->cb) - 8)
>>>
>>> to
>>>
>>> #define IEEE80211_TX_INFO_DRIVER_DATA_SIZE \
>>>         (sizeof(((struct sk_buff *)0)->cb) - 12)
>>>
>>> might help to get it to compile. If that doesn't work, try -16.
>>>
>>>
>> That didn't work, neither with -12 or -16.
> 
> I'll give it a try myself, please wait a few minutes.

We can't fit them into the cb together, I don't see a way to
shrink ieee80211_tx_info.

Maybe one of the wireless folks can suggest something? Is it
really necessary to pass the full struct ieee80211_tx_info
through the qdisc layer, or could the struct be split? It
needs to find a way to co-exist peacefully with qdiscs'
skb->cb usage.


  reply	other threads:[~2008-07-23 16:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-11144-10286@http.bugzilla.kernel.org/>
2008-07-22 10:48 ` [Bugme-new] [Bug 11144] New: dhcp doesn't work with iwl4965 Andrew Morton
2008-07-22 10:52   ` Patrick McHardy
     [not found]   ` <20080722034850.dbbc5566.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-23  7:58     ` François Valenduc
2008-07-23  7:59       ` François Valenduc
     [not found]       ` <4886E49D.6010700-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23  8:05         ` Andrew Morton
     [not found]           ` <20080723010522.389a948f.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2008-07-23  9:17             ` François Valenduc
     [not found]               ` <4886F727.6010301-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23 10:12                 ` Patrick McHardy
     [not found]                   ` <48870425.50908-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-23 11:29                     ` François Valenduc
     [not found]                       ` <48871632.3010205-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23 11:31                         ` Patrick McHardy
2008-07-23 11:58                           ` François Valenduc
     [not found]                           ` <4887169B.6090102-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-23 12:36                             ` François Valenduc
2008-07-23 12:44                               ` Patrick McHardy
     [not found]                                 ` <488727B3.7040007-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-23 12:51                                   ` Patrick McHardy
2008-07-23 14:57                                     ` François Valenduc
2008-07-23 15:18                                       ` Patrick McHardy
2008-07-23 15:19                                         ` Patrick McHardy
2008-07-23 15:42                                           ` François Valenduc
     [not found]                                             ` <4887514C.6080903-bmtTS95sd5BUM80lpFwj4w@public.gmane.org>
2008-07-23 15:52                                               ` Patrick McHardy
2008-07-23 15:58                                                 ` François Valenduc
2008-07-23 15:59                                                   ` Patrick McHardy
2008-07-23 16:25                                                     ` Patrick McHardy [this message]
2008-07-23 21:21                                                       ` David Miller
     [not found]                                                         ` <20080723.142147.61941255.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-24  8:58                                                           ` Patrick McHardy
     [not found]                                                             ` <48884451.1090703-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-24 10:17                                                               ` Tomas Winkler
     [not found]                                                                 ` <1ba2fa240807240317g15f6ba84h91b513cce75975e9-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-24 10:19                                                                   ` Patrick McHardy
     [not found]                                                                     ` <48885743.8030505-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>
2008-07-24 11:35                                                                       ` Tomas Winkler
     [not found]                                                                         ` <1ba2fa240807240435g36daa80at254144afffc39c32-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-07-24 11:45                                                                           ` Johannes Berg
2008-07-30 18:04                                                                             ` François Valenduc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48875B8C.2090800@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=francois.valenduc@tvcablenet.be \
    --cc=jussi.kivilinna@mbnet.fi \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).