From: Patrick McHardy <kaber@trash.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Ranjit Manomohan <ranjitm@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
lizf@cn.fujitsu.com, menage@google.com
Subject: Re: [PATCH] Traffic control cgroups subsystem
Date: Thu, 24 Jul 2008 00:34:24 +0200 [thread overview]
Message-ID: <4887B1F0.3000407@trash.net> (raw)
In-Reply-To: <20080723150536.ded38b22.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 22 Jul 2008 10:44:18 -0700 (PDT)
> Ranjit Manomohan <ranjitm@google.com> wrote:
>
>> @@ -359,7 +370,12 @@ static int flow_classify(struct sk_buff *skb, struct tcf_proto *tp,
>> classid %= f->divisor;
>>
>> res->class = 0;
>> - res->classid = TC_H_MAKE(f->baseclass, f->baseclass + classid);
>> +
>> + if (key == FLOW_KEY_CGROUP_CLASSID)
>> + res->classid = TC_H_MAKE(f->baseclass, classid);
>> + else
>> + res->classid = TC_H_MAKE(f->baseclass,
>> + f->baseclass + classid);
>
> This causes a warning:
>
> net/sched/cls_flow.c: In function 'flow_classify':
> net/sched/cls_flow.c:344: warning: 'key' may be used uninitialized in this function
>
> that warning is a non-issue if we happen to know that f->nkeys can
> never be zero. I don't know if that is guaranteed at this code site?
It is by the flow_change() function, but special casing the
CGROUP_CLASSID is not acceptable anyway. There should be no
need for that, a simple linear mapping to classids is done
by default in mapping mode, the sk_cgroup_classid simply
shouldn't include qdisc IDs.
next prev parent reply other threads:[~2008-07-23 22:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 17:44 [PATCH] Traffic control cgroups subsystem Ranjit Manomohan
2008-07-23 22:05 ` Andrew Morton
2008-07-23 22:34 ` Patrick McHardy [this message]
2008-07-23 23:54 ` Ranjit Manomohan
2008-07-24 0:17 ` Patrick McHardy
2008-07-24 23:45 ` Thomas Graf
2008-07-25 1:16 ` Ranjit Manomohan
2008-07-25 9:29 ` Thomas Graf
2008-07-25 1:18 ` Paul Menage
-- strict thread matches above, loose matches on Subject: below --
2008-07-22 4:08 Ranjit Manomohan
2008-07-22 10:35 ` Patrick McHardy
2008-07-22 12:14 ` Paul Menage
2008-07-22 12:48 ` Patrick McHardy
2008-07-22 12:56 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4887B1F0.3000407@trash.net \
--to=kaber@trash.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=netdev@vger.kernel.org \
--cc=ranjitm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).