From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: jarkao2@gmail.com, denys@visp.net.lb, netdev@vger.kernel.org
Subject: Re: [PATCH] Re: SFQ depth limit
Date: Thu, 24 Jul 2008 10:45:39 +0200 [thread overview]
Message-ID: <48884133.8070301@trash.net> (raw)
In-Reply-To: <20080723.213443.37820788.davem@davemloft.net>
David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Sun, 29 Jun 2008 21:11:13 +0200
>
>
>> sch_sfq: dump a real number of flows
>>
>> Dump the "flows" number according to the number of active flows
>> instead of repeating the "limit".
>>
>
> Looks reasonable, applied, thanks Jarek.
I'm not sure we should do this, this removes the symetry between
->init/change and ->dump. Its not a big deal in this case since
flows is unused in ->init anyway, but still its a not so nice
precedent. Such things should normally be put in the statistics.
next prev parent reply other threads:[~2008-07-24 8:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 19:02 SFQ depth limit Denys Fedoryshchenko
2008-06-29 19:11 ` [PATCH] " Jarek Poplawski
2008-06-29 19:38 ` Denys Fedoryshchenko
2008-07-24 4:34 ` David Miller
2008-07-24 8:45 ` Patrick McHardy [this message]
2008-07-24 9:49 ` Jarek Poplawski
2008-07-24 9:57 ` Patrick McHardy
2008-07-24 10:53 ` [PATCH] pkt_sched: sch_sfq: revert "dump a real number of flows" patch Jarek Poplawski
2008-07-26 9:29 ` David Miller
2008-07-26 10:58 ` Jarek Poplawski
2008-07-27 0:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48884133.8070301@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=denys@visp.net.lb \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).