From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip_vs.h Date: Thu, 24 Jul 2008 13:40:44 +0200 Message-ID: <48886A3C.7050906@trash.net> References: <1216894489-13060-1-git-send-email-juliusv@google.com> <20080724111434.GA30382@verge.net.au> <488865FA.4040002@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Simon Horman , lvs-devel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, vbusam@google.com To: Julius Volz Return-path: In-Reply-To: Sender: lvs-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Julius Volz wrote: > On Thu, Jul 24, 2008 at 1:22 PM, Patrick McHardy wrote: >>>> +/* Move it to better place one day, for now keep it unique */ >>>> +#define NFC_IPVS_PROPERTY 0x10000 >> Does this have any connection to the skb flag? If so, does >> it really belong in the userspace interface? > > This doesn't seem to be used at all anymore, but I didn't want to > remove it in the same patch... should I? I'm not sure if this is (or has been) used by userspace, someone more familiar with IPVS should answer that. >>>> +struct ip_vs_service_user { >>>> + /* virtual service addresses */ >>>> + u_int16_t protocol; >>>> + __be32 addr; /* virtual ip address */ >>>> + __be16 port; >> If you switch the above two you plug two holes in the struct. > > Unfortunately, these structs all have to stay as they are because they > are used by old ipvsadms. That was the whole reason for implementing > the Netlink interface. Ah I see, I assumed you would be using them in the new interface :) So thats fine obviously.