From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() Date: Thu, 24 Jul 2008 11:39:25 -0700 Message-ID: <4888CC5D.9030800@goop.org> References: <1216912546-6971-1-git-send-email-ehabkost@redhat.com> <1216912546-6971-2-git-send-email-ehabkost@redhat.com> <4888A3B7.8060901@goop.org> <4888CA2A.1060509@garzik.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Eduardo Habkost , Ingo Molnar , linux-kernel@vger.kernel.org, NetDev , David Miller To: Jeff Garzik Return-path: Received: from gw.goop.org ([64.81.55.164]:51057 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbYGXSj3 (ORCPT ); Thu, 24 Jul 2008 14:39:29 -0400 In-Reply-To: <4888CA2A.1060509@garzik.org> Sender: netdev-owner@vger.kernel.org List-ID: Jeff Garzik wrote: > Jeremy Fitzhardinge wrote: >> Eduardo Habkost wrote: >>> xen-netfront was waking the queue before calling netif_start_queue(), >>> triggering the BUG_ON() on __netif_schedule(). >>> >>> Signed-off-by: Eduardo Habkost >>> >> Ok, >> Acked-by: Jeremy Fitzhardinge >> >> but Ingo, do you want to pick this up? You're gathering a collection >> of these patches anyway, or should we kick it over to Dave/Jeff? >> >> J >> >>> --- >>> drivers/net/xen-netfront.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >>> index 902bbe7..c749bdb 100644 >>> --- a/drivers/net/xen-netfront.c >>> +++ b/drivers/net/xen-netfront.c >>> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) >>> } >>> spin_unlock_bh(&np->rx_lock); >>> >>> - xennet_maybe_wake_tx(dev); >>> + netif_start_queue(dev); > > This is clearly a net driver change, it should go this way... OK, all your's. J