From: Wang Chen <wangchen@cn.fujitsu.com>
To: Jeff Garzik <jgarzik@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
torvalds@linux-foundation.org, NETDEV <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Alan Cox <alan@redhat.com>
Subject: Re: [build error] ERROR: "NS8390_init" [drivers/net/ne.ko] undefined!
Date: Fri, 25 Jul 2008 13:48:51 +0800 [thread overview]
Message-ID: <48896943.7090902@cn.fujitsu.com> (raw)
In-Reply-To: <4889437A.5060907@cn.fujitsu.com>
Jeff
commit "net 8390p: fix interface usage"(f0084a36d4d7) fixed some drivers which
use wrong API of NS8390p.
But ne.c seems didn't be fixed completely.
I've got the following build err:
---
Kernel: arch/x86/boot/bzImage is ready (#21)
Building modules, stage 2.
MODPOST 423 modules
ERROR: "NS8390_init" [drivers/net/ne.ko] undefined!
WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
---
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Alan Cox <alan@redhat.com>
---
diff --git a/drivers/net/ne.c b/drivers/net/ne.c
index 2fec612..4a8a4b1 100644
--- a/drivers/net/ne.c
+++ b/drivers/net/ne.c
@@ -536,7 +536,7 @@ static int __init ne_probe1(struct net_device *dev, unsigned long ioaddr)
#ifdef CONFIG_NET_POLL_CONTROLLER
dev->poll_controller = eip_poll;
#endif
- NS8390_init(dev, 0);
+ NS8390p_init(dev, 0);
ret = register_netdev(dev);
if (ret)
@@ -794,7 +794,7 @@ retry:
if (time_after(jiffies, dma_start + 2*HZ/100)) { /* 20ms */
printk(KERN_WARNING "%s: timeout waiting for Tx RDC.\n", dev->name);
ne_reset_8390(dev);
- NS8390_init(dev,1);
+ NS8390p_init(dev,1);
break;
}
@@ -855,7 +855,7 @@ static int ne_drv_resume(struct platform_device *pdev)
if (netif_running(dev)) {
ne_reset_8390(dev);
- NS8390_init(dev, 1);
+ NS8390p_init(dev, 1);
netif_device_attach(dev);
}
return 0;
prev parent reply other threads:[~2008-07-25 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 3:07 [build error] ERROR: "NS8390_init" [drivers/net/ne.ko] undefined! Wang Chen
2008-07-25 5:48 ` Wang Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48896943.7090902@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=alan@redhat.com \
--cc=davem@davemloft.net \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).