* [PATCH] blackfin_mac: unneeded assignment
@ 2008-07-25 18:46 Stephen Hemminger
2008-07-29 6:48 ` Bryan Wu
2008-07-29 22:24 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2008-07-25 18:46 UTC (permalink / raw)
To: cooloney, Jeff Garzik; +Cc: netdev
skb->dev is set by eth_type_trans already.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/bfin_mac.c 2008-07-25 10:19:53.000000000 -0700
+++ b/drivers/net/bfin_mac.c 2008-07-25 10:20:53.000000000 -0700
@@ -691,7 +691,6 @@ static void bfin_mac_rx(struct net_devic
(unsigned long)skb->tail);
dev->last_rx = jiffies;
- skb->dev = dev;
skb->protocol = eth_type_trans(skb, dev);
#if defined(BFIN_MAC_CSUM_OFFLOAD)
skb->csum = current_rx_ptr->status.ip_payload_csum;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blackfin_mac: unneeded assignment
2008-07-25 18:46 [PATCH] blackfin_mac: unneeded assignment Stephen Hemminger
@ 2008-07-29 6:48 ` Bryan Wu
2008-07-29 22:24 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Bryan Wu @ 2008-07-29 6:48 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Jeff Garzik, netdev
On Sat, Jul 26, 2008 at 2:46 AM, Stephen Hemminger
<shemminger@vyatta.com> wrote:
> skb->dev is set by eth_type_trans already.
>
Right, I'd love to add it into my queue.
Applied.
Acked-by: Bryan Wu <cooloney@kernel.org>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
>
> --- a/drivers/net/bfin_mac.c 2008-07-25 10:19:53.000000000 -0700
> +++ b/drivers/net/bfin_mac.c 2008-07-25 10:20:53.000000000 -0700
> @@ -691,7 +691,6 @@ static void bfin_mac_rx(struct net_devic
> (unsigned long)skb->tail);
>
> dev->last_rx = jiffies;
> - skb->dev = dev;
> skb->protocol = eth_type_trans(skb, dev);
> #if defined(BFIN_MAC_CSUM_OFFLOAD)
> skb->csum = current_rx_ptr->status.ip_payload_csum;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] blackfin_mac: unneeded assignment
2008-07-25 18:46 [PATCH] blackfin_mac: unneeded assignment Stephen Hemminger
2008-07-29 6:48 ` Bryan Wu
@ 2008-07-29 22:24 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-07-29 22:24 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: cooloney, netdev
Stephen Hemminger wrote:
> skb->dev is set by eth_type_trans already.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-29 22:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25 18:46 [PATCH] blackfin_mac: unneeded assignment Stephen Hemminger
2008-07-29 6:48 ` Bryan Wu
2008-07-29 22:24 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).