From: Jeff Garzik <jgarzik@pobox.com>
To: David Brownell <david-b@pacbell.net>
Cc: Network development list <netdev@vger.kernel.org>,
Claudio Lanconelli <lanconelli.claudio@eptar.com>
Subject: Re: [patch 2.6.26-git] enc28j60: don't specify (wrong) IRQ type
Date: Tue, 29 Jul 2008 18:24:57 -0400 [thread overview]
Message-ID: <488F98B9.90909@pobox.com> (raw)
In-Reply-To: <200807241747.56954.david-b@pacbell.net>
David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> Recent changes to the IRQ framework have made passing the wrong
> trigger type to request_irq() become a fatal error. In the case
> of the enc28j60 driver, it stopped working in my test harness.
>
> (Specifically: the signal detects "pin change" events, both edges,
> not just falling edges. Similarly, other boards might route it
> through an inverter. Trigger type are board-specific.)
>
> This fixes that problem by the usual fix of expecting board setup
> code to have set up the correct IRQ trigger type. The best known
> example of that being x86 setup.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
applied
prev parent reply other threads:[~2008-07-29 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 0:47 [patch 2.6.26-git] enc28j60: don't specify (wrong) IRQ type David Brownell
2008-07-29 22:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=488F98B9.90909@pobox.com \
--to=jgarzik@pobox.com \
--cc=david-b@pacbell.net \
--cc=lanconelli.claudio@eptar.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).