From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: David Miller <davem@davemloft.net>
Cc: gerrit@erg.abdn.ac.uk, netdev@vger.kernel.org
Subject: Re: [RFC] sctp/tcp: Question -- ICMPv4 length check (not) redundant?
Date: Wed, 30 Jul 2008 08:49:38 -0400 [thread overview]
Message-ID: <48906362.2090902@hp.com> (raw)
In-Reply-To: <20080730.031935.61479223.davem@davemloft.net>
David Miller wrote:
> From: Vlad Yasevich <vladislav.yasevich@hp.com>
> Date: Mon, 28 Jul 2008 14:09:55 -0400
>
>> The IPv6 checks are much different. The MUST requirement is to provide as much
>> data as possible upto IPv6 min mtu. So, the IPv6 icmp code should probably look
>> to see if min(payload_len, min_mtu) is provided.
>
> "Be liberal in what you accept..." -Jon Postel
Yeah, that check is really too strict.
>
> Also, do you know any case where 576 bytes won't provide enough
> quoted packet bytes? :-)
>
Yes, I've seen a case where a full 1280 was needed. It involved a
very convoluted packet that had extension headers and then went
through 2 encapsulations. This was an extreme test scenario and
not a real world example.
-vlad
next prev parent reply other threads:[~2008-07-30 12:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 15:20 [RFC] sctp/tcp: Question -- ICMPv4 length check (not) redundant? Gerrit Renker
2008-07-26 2:15 ` Vlad Yasevich
2008-07-26 4:38 ` David Miller
2008-07-26 7:03 ` Gerrit Renker
2008-07-26 7:36 ` David Miller
2008-07-26 8:10 ` Gerrit Renker
2008-07-27 4:48 ` Herbert Xu
2008-07-27 4:51 ` Herbert Xu
2008-07-28 11:25 ` Gerrit Renker
2008-07-28 13:08 ` Herbert Xu
2008-07-28 13:14 ` Vlad Yasevich
2008-07-28 17:08 ` Gerrit Renker
2008-07-28 17:27 ` Vlad Yasevich
2008-07-28 17:44 ` Gerrit Renker
2008-07-28 18:09 ` Vlad Yasevich
2008-07-30 10:19 ` David Miller
2008-07-30 12:49 ` Vlad Yasevich [this message]
2008-07-29 1:56 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48906362.2090902@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).