From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.27-rc1]: fix NE2000 linkage error
Date: Wed, 30 Jul 2008 13:55:32 -0400 [thread overview]
Message-ID: <4890AB14.1030009@garzik.org> (raw)
In-Reply-To: <200807301144.m6UBitOG022822@harpo.it.uu.se>
Mikael Pettersson wrote:
> Trying to build with CONFIG_NE2000=m fails with:
>
> scripts/mod/modpost -o /tmp/tmp/linux-2.6.27-rc1/Module.symvers -S -s
> ERROR: "NS8390_init" [drivers/net/ne.ko] undefined!
>
> This is because the split of 8390 into pausing and non-pausing
> versions was incompletely propagated to ne.c. This fixes it.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> ---
>
> --- linux-2.6.27-rc1/drivers/net/ne.c.~1~ 2008-07-29 10:40:11.000000000 +0200
> +++ linux-2.6.27-rc1/drivers/net/ne.c 2008-07-30 13:17:16.000000000 +0200
> @@ -536,7 +536,7 @@ static int __init ne_probe1(struct net_d
> #ifdef CONFIG_NET_POLL_CONTROLLER
> dev->poll_controller = eip_poll;
> #endif
> - NS8390_init(dev, 0);
> + NS8390p_init(dev, 0);
>
> ret = register_netdev(dev);
> if (ret)
> @@ -794,7 +794,7 @@ retry:
> if (time_after(jiffies, dma_start + 2*HZ/100)) { /* 20ms */
> printk(KERN_WARNING "%s: timeout waiting for Tx RDC.\n", dev->name);
> ne_reset_8390(dev);
> - NS8390_init(dev,1);
> + NS8390p_init(dev, 1);
> break;
> }
>
> @@ -855,7 +855,7 @@ static int ne_drv_resume(struct platform
>
> if (netif_running(dev)) {
> ne_reset_8390(dev);
> - NS8390_init(dev, 1);
> + NS8390p_init(dev, 1);
> netif_device_attach(dev);
Yep, already got this one, but thanks!
next prev parent reply other threads:[~2008-07-30 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 11:44 [PATCH 2.6.27-rc1]: fix NE2000 linkage error Mikael Pettersson
2008-07-30 14:04 ` Alan Cox
2008-07-30 17:55 ` Jeff Garzik [this message]
2008-07-30 21:15 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4890AB14.1030009@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).