* [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code
@ 2008-07-21 7:57 Julia Lawall
2008-07-29 8:14 ` Jan-Bernd Themann
2008-07-30 21:23 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2008-07-21 7:57 UTC (permalink / raw)
To: jgarzik, raisch, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.
The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression l;
@@
mutex_lock(l);
... when != mutex_unlock(l)
when any
when strict
(
if (...) { ... when != mutex_unlock(l)
+ mutex_unlock(l);
return ...;
}
|
mutex_unlock(l);
)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
diff -u -p a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
--- a/drivers/net/ehea/ehea_main.c
+++ b/drivers/net/ehea/ehea_main.c
@@ -2937,9 +2937,9 @@ static void ehea_rereg_mrs(struct work_s
}
}
}
- mutex_unlock(&dlpar_mem_lock);
- ehea_info("re-initializing driver complete");
+ ehea_info("re-initializing driver complete");
out:
+ mutex_unlock(&dlpar_mem_lock);
return;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code
2008-07-21 7:57 [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code Julia Lawall
@ 2008-07-29 8:14 ` Jan-Bernd Themann
2008-07-30 21:23 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jan-Bernd Themann @ 2008-07-29 8:14 UTC (permalink / raw)
To: Julia Lawall; +Cc: jgarzik, raisch, netdev, linux-kernel, kernel-janitors
On Monday 21 July 2008 09:57, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The mutex is released on a successful return, so it would seem that it
> should be released on an error return as well.
>
> The semantic patch finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression l;
> @@
>
> mutex_lock(l);
> ... when != mutex_unlock(l)
> when any
> when strict
> (
> if (...) { ... when != mutex_unlock(l)
> + mutex_unlock(l);
> return ...;
> }
> |
> mutex_unlock(l);
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> diff -u -p a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
> --- a/drivers/net/ehea/ehea_main.c
> +++ b/drivers/net/ehea/ehea_main.c
> @@ -2937,9 +2937,9 @@ static void ehea_rereg_mrs(struct work_s
> }
> }
> }
> - mutex_unlock(&dlpar_mem_lock);
> - ehea_info("re-initializing driver complete");
> + ehea_info("re-initializing driver complete");
> out:
> + mutex_unlock(&dlpar_mem_lock);
> return;
> }
>
> --
The patch looks good.
Acked-by: Jan-Bernd Themann <themann@de.ibm.com>
Thanks,
Jan-Bernd
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code
2008-07-21 7:57 [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code Julia Lawall
2008-07-29 8:14 ` Jan-Bernd Themann
@ 2008-07-30 21:23 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-07-30 21:23 UTC (permalink / raw)
To: Julia Lawall; +Cc: raisch, netdev, linux-kernel, kernel-janitors
Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The mutex is released on a successful return, so it would seem that it
> should be released on an error return as well.
>
> The semantic patch finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> expression l;
> @@
>
> mutex_lock(l);
> ... when != mutex_unlock(l)
> when any
> when strict
> (
> if (...) { ... when != mutex_unlock(l)
> + mutex_unlock(l);
> return ...;
> }
> |
> mutex_unlock(l);
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-30 21:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21 7:57 [PATCH 2/7] drivers/net/ehea/ehea_main.c: Release mutex in error handling code Julia Lawall
2008-07-29 8:14 ` Jan-Bernd Themann
2008-07-30 21:23 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).