From: Jonathan Cameron <jic23@cam.ac.uk>
To: netdev@vger.kernel.org
Cc: nico@cam.org
Subject: [PATCH 2.6.27-rc1] smc91x.c smc_drv_remove bugfix? (been there a while!)
Date: Thu, 31 Jul 2008 20:27:56 +0100 [thread overview]
Message-ID: <4892123C.2060007@cam.ac.uk> (raw)
From: Jonathan Cameron
Trivial bug fix for typo in smc91x.c that results in null pointer dereference
Signed-of-by: Jonathan Cameron
--
Could just have submitted this as a bug report, but as it's a trivial patch
this seemed easier. Clearly this will be irrelevant if people have moved board
configs to using resource names, but for now... Not been involved with net drivers
before so sorry if I've sent it to the wrong people!
/drivers/net/smc91x.c 2008-07-31 12:02:47.000000000 +0100
+++ b/drivers/net/smc91x.c 2008-07-31 20:06:19.000000000 +0100
@@ -2255,7 +2255,7 @@ static int smc_drv_remove(struct platfor
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "smc91x-regs");
if (!res)
- platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
release_mem_region(res->start, SMC_IO_EXTENT);
free_netdev(ndev);
next reply other threads:[~2008-07-31 19:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 19:27 Jonathan Cameron [this message]
2008-08-08 12:25 ` [PATCH 2.6.27-rc1] smc91x.c smc_drv_remove bug Jonathan Cameron
2008-08-22 9:48 ` [PATCH 2.6.27-rc4] smc91x bug fix to avoid null pointer dereference Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4892123C.2060007@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).