* Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() [not found] ` <1216912546-6971-2-git-send-email-ehabkost@redhat.com> @ 2008-07-24 15:45 ` Jeremy Fitzhardinge 2008-07-24 18:30 ` Jeff Garzik 0 siblings, 1 reply; 5+ messages in thread From: Jeremy Fitzhardinge @ 2008-07-24 15:45 UTC (permalink / raw) To: Eduardo Habkost Cc: Ingo Molnar, linux-kernel, NetDev, Jeff Garzik, David Miller Eduardo Habkost wrote: > xen-netfront was waking the queue before calling netif_start_queue(), > triggering the BUG_ON() on __netif_schedule(). > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > Ok, Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> but Ingo, do you want to pick this up? You're gathering a collection of these patches anyway, or should we kick it over to Dave/Jeff? J > --- > drivers/net/xen-netfront.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > index 902bbe7..c749bdb 100644 > --- a/drivers/net/xen-netfront.c > +++ b/drivers/net/xen-netfront.c > @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) > } > spin_unlock_bh(&np->rx_lock); > > - xennet_maybe_wake_tx(dev); > + netif_start_queue(dev); > > return 0; > } > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() 2008-07-24 15:45 ` [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() Jeremy Fitzhardinge @ 2008-07-24 18:30 ` Jeff Garzik 2008-07-24 18:39 ` Jeremy Fitzhardinge 0 siblings, 1 reply; 5+ messages in thread From: Jeff Garzik @ 2008-07-24 18:30 UTC (permalink / raw) To: Jeremy Fitzhardinge Cc: Eduardo Habkost, Ingo Molnar, linux-kernel, NetDev, David Miller Jeremy Fitzhardinge wrote: > Eduardo Habkost wrote: >> xen-netfront was waking the queue before calling netif_start_queue(), >> triggering the BUG_ON() on __netif_schedule(). >> >> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> >> > Ok, > Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> > > but Ingo, do you want to pick this up? You're gathering a collection of > these patches anyway, or should we kick it over to Dave/Jeff? > > J > >> --- >> drivers/net/xen-netfront.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >> index 902bbe7..c749bdb 100644 >> --- a/drivers/net/xen-netfront.c >> +++ b/drivers/net/xen-netfront.c >> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) >> } >> spin_unlock_bh(&np->rx_lock); >> >> - xennet_maybe_wake_tx(dev); >> + netif_start_queue(dev); This is clearly a net driver change, it should go this way... Jeff ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() 2008-07-24 18:30 ` Jeff Garzik @ 2008-07-24 18:39 ` Jeremy Fitzhardinge 2008-07-31 20:03 ` Eduardo Habkost 0 siblings, 1 reply; 5+ messages in thread From: Jeremy Fitzhardinge @ 2008-07-24 18:39 UTC (permalink / raw) To: Jeff Garzik Cc: Eduardo Habkost, Ingo Molnar, linux-kernel, NetDev, David Miller Jeff Garzik wrote: > Jeremy Fitzhardinge wrote: >> Eduardo Habkost wrote: >>> xen-netfront was waking the queue before calling netif_start_queue(), >>> triggering the BUG_ON() on __netif_schedule(). >>> >>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> >>> >> Ok, >> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> >> >> but Ingo, do you want to pick this up? You're gathering a collection >> of these patches anyway, or should we kick it over to Dave/Jeff? >> >> J >> >>> --- >>> drivers/net/xen-netfront.c | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >>> index 902bbe7..c749bdb 100644 >>> --- a/drivers/net/xen-netfront.c >>> +++ b/drivers/net/xen-netfront.c >>> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) >>> } >>> spin_unlock_bh(&np->rx_lock); >>> >>> - xennet_maybe_wake_tx(dev); >>> + netif_start_queue(dev); > > This is clearly a net driver change, it should go this way... OK, all your's. J ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() 2008-07-24 18:39 ` Jeremy Fitzhardinge @ 2008-07-31 20:03 ` Eduardo Habkost 2008-07-31 20:09 ` Jeremy Fitzhardinge 0 siblings, 1 reply; 5+ messages in thread From: Eduardo Habkost @ 2008-07-31 20:03 UTC (permalink / raw) To: Jeff Garzik, David Miller Cc: Jeremy Fitzhardinge, Ingo Molnar, linux-kernel, NetDev On Thu, Jul 24, 2008 at 11:39:25AM -0700, Jeremy Fitzhardinge wrote: > Jeff Garzik wrote: >> Jeremy Fitzhardinge wrote: >>> Eduardo Habkost wrote: >>>> xen-netfront was waking the queue before calling netif_start_queue(), >>>> triggering the BUG_ON() on __netif_schedule(). >>>> >>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> >>>> >>> Ok, >>> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> >>> >>> but Ingo, do you want to pick this up? You're gathering a collection of >>> these patches anyway, or should we kick it over to Dave/Jeff? >>> >>> J >>> >>>> --- >>>> drivers/net/xen-netfront.c | 2 +- >>>> 1 files changed, 1 insertions(+), 1 deletions(-) >>>> >>>> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c >>>> index 902bbe7..c749bdb 100644 >>>> --- a/drivers/net/xen-netfront.c >>>> +++ b/drivers/net/xen-netfront.c >>>> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) >>>> } >>>> spin_unlock_bh(&np->rx_lock); >>>> - xennet_maybe_wake_tx(dev); >>>> + netif_start_queue(dev); >> >> This is clearly a net driver change, it should go this way... > > OK, all your's. I didn't find it on any git repository. Is it queued somewhere? If not, should I resend? -- Eduardo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() 2008-07-31 20:03 ` Eduardo Habkost @ 2008-07-31 20:09 ` Jeremy Fitzhardinge 0 siblings, 0 replies; 5+ messages in thread From: Jeremy Fitzhardinge @ 2008-07-31 20:09 UTC (permalink / raw) To: Eduardo Habkost Cc: Jeff Garzik, David Miller, Ingo Molnar, linux-kernel, NetDev Eduardo Habkost wrote: > I didn't find it on any git repository. Is it queued somewhere? If not, > should I resend? > Yes, I think it fell through the cracks. Resend to Jeff. J ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-07-31 20:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1216912546-6971-1-git-send-email-ehabkost@redhat.com>
[not found] ` <1216912546-6971-2-git-send-email-ehabkost@redhat.com>
2008-07-24 15:45 ` [PATCH 2/2] xen-netfront: call netif_start_queue() on xennet_open() Jeremy Fitzhardinge
2008-07-24 18:30 ` Jeff Garzik
2008-07-24 18:39 ` Jeremy Fitzhardinge
2008-07-31 20:03 ` Eduardo Habkost
2008-07-31 20:09 ` Jeremy Fitzhardinge
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).