* [PATCH] net/ipv4/route.c: fix build error [not found] ` <20080727214250.GA5917@elte.hu> @ 2008-08-01 1:40 ` Wang Chen 2008-08-01 3:51 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Wang Chen @ 2008-08-01 1:40 UTC (permalink / raw) To: David Miller; +Cc: Ingo Molnar, viro, NETDEV Dave, the build error keeps showing several days. From: Ingo Molnar <mingo@elte.hu> Date: Sun, 27 Jul 2008 23:51:45 +0200 Subject: [PATCH] net/ipv4/route.c: fix build error fix: net/ipv4/route.c: In function 'ip_static_sysctl_init': net/ipv4/route.c:3225: error: 'ipv4_route_path' undeclared (first use in this function) net/ipv4/route.c:3225: error: (Each undeclared identifier is reported only once net/ipv4/route.c:3225: error: for each function it appears in.) net/ipv4/route.c:3225: error: 'ipv4_route_table' undeclared (first use in this function) Signed-off-by: Ingo Molnar <mingo@elte.hu> --- net/ipv4/route.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 380d647..d7bf056 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -3222,7 +3222,9 @@ int __init ip_rt_init(void) */ void __init ip_static_sysctl_init(void) { +#ifdef CONFIG_SYSCTL register_sysctl_paths(ipv4_route_path, ipv4_route_table); +#endif } EXPORT_SYMBOL(__ip_select_ident); -- ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ipv4/route.c: fix build error 2008-08-01 1:40 ` [PATCH] net/ipv4/route.c: fix build error Wang Chen @ 2008-08-01 3:51 ` David Miller 2008-08-06 13:04 ` Paulius Zaleckas 0 siblings, 1 reply; 4+ messages in thread From: David Miller @ 2008-08-01 3:51 UTC (permalink / raw) To: wangchen; +Cc: mingo, viro, netdev From: Wang Chen <wangchen@cn.fujitsu.com> Date: Fri, 01 Aug 2008 09:40:59 +0800 > Dave, the build error keeps showing several days. I've applied Ingo's patch, thanks. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ipv4/route.c: fix build error 2008-08-01 3:51 ` David Miller @ 2008-08-06 13:04 ` Paulius Zaleckas 2008-08-07 1:31 ` David Miller 0 siblings, 1 reply; 4+ messages in thread From: Paulius Zaleckas @ 2008-08-06 13:04 UTC (permalink / raw) To: David Miller; +Cc: wangchen, mingo, viro, netdev David Miller wrote: > From: Wang Chen <wangchen@cn.fujitsu.com> > Date: Fri, 01 Aug 2008 09:40:59 +0800 > >> Dave, the build error keeps showing several days. > > I've applied Ingo's patch, thanks. And after merging this patch: [PATCH] ipv4_static_sysctl_init() should be under CONFIG_SYSCTL author Al Viro <viro@zeniv.linux.org.uk> Wed, 30 Jul 2008 10:32:52 +0000 (06:32 -0400) committer Al Viro <viro@zeniv.linux.org.uk> Fri, 1 Aug 2008 15:25:22 +0000 (11:25 -0400) commit a1bc6eb4b499ae67ada9a01660010580b6569403 This function is over ifdef'ed :) #ifdef CONFIG_SYSCTL /* * We really need to sanitize the damn ipv4 init order, then all * this nonsense will go away. */ void __init ip_static_sysctl_init(void) { #ifdef CONFIG_SYSCTL register_sysctl_paths(ipv4_route_path, ipv4_route_table); #endif } #endif BR, Paulius Zaleckas ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/ipv4/route.c: fix build error 2008-08-06 13:04 ` Paulius Zaleckas @ 2008-08-07 1:31 ` David Miller 0 siblings, 0 replies; 4+ messages in thread From: David Miller @ 2008-08-07 1:31 UTC (permalink / raw) To: paulius.zaleckas; +Cc: wangchen, mingo, viro, netdev From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt> Date: Wed, 06 Aug 2008 16:04:51 +0300 > This function is over ifdef'ed :) > > #ifdef CONFIG_SYSCTL > /* > * We really need to sanitize the damn ipv4 init order, then all > * this nonsense will go away. > */ > void __init ip_static_sysctl_init(void) > { > #ifdef CONFIG_SYSCTL > register_sysctl_paths(ipv4_route_path, ipv4_route_table); > #endif > } > #endif Thanks, I've gotten rid of the inner ones in my tree. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-08-07 1:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080727075933.GB28946@ZenIV.linux.org.uk>
[not found] ` <20080727.044118.102038262.davem@davemloft.net>
[not found] ` <20080727213905.GA4499@elte.hu>
[not found] ` <20080727214250.GA5917@elte.hu>
2008-08-01 1:40 ` [PATCH] net/ipv4/route.c: fix build error Wang Chen
2008-08-01 3:51 ` David Miller
2008-08-06 13:04 ` Paulius Zaleckas
2008-08-07 1:31 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).