From: Wang Chen <wangchen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH]&[Question] netdevice: Use netdev_priv()
Date: Fri, 01 Aug 2008 18:35:24 +0800 [thread overview]
Message-ID: <4892E6EC.3040201@cn.fujitsu.com> (raw)
In-Reply-To: <20080801.032424.114777556.davem@davemloft.net>
David Miller said the following on 2008-8-1 18:24:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Fri, 01 Aug 2008 18:16:32 +0800
>
>> Then next question comes.
>> We *have to* convert the drivers to use netdev_priv(), right?
>
> No, we don't.
>
>> Because, netdev->priv == netdev_priv() maybe change again in future,
>> just as before.
>
> We will work to prevent that. I should not have allowed it to happen
> in the first place. :-)
>
How about add a comment to netdev->priv
void *priv; /* pointer to private data, referent me by netdev_priv()*/
next prev parent reply other threads:[~2008-08-01 10:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 9:50 [PATCH]&[Question] netdevice: Use netdev_priv() Wang Chen
2008-08-01 10:08 ` David Miller
2008-08-01 10:16 ` Wang Chen
2008-08-01 10:24 ` David Miller
2008-08-01 10:35 ` Wang Chen [this message]
2008-08-01 11:05 ` David Miller
2008-08-05 9:55 ` Wang Chen
2008-08-05 10:04 ` David Miller
2008-08-05 17:51 ` Divy Le Ray
2008-08-06 4:21 ` Wang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4892E6EC.3040201@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).