From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
yjwei@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH] inet6: Fix paramater issue of inet6_csk_xmit
Date: Sat, 02 Aug 2008 19:26:29 -0400 [thread overview]
Message-ID: <4894ED25.6040200@hp.com> (raw)
In-Reply-To: <20080802003016.GA24295@gondor.apana.org.au>
Herbert Xu wrote:
> On Fri, Aug 01, 2008 at 10:50:17AM -0400, Vlad Yasevich wrote:
>>> + inet->pmtudisc = transport->param_flags & SPP_PMTUD_ENABLE ?
>>> + IP_PMTUDISC_DO : IP_PMTUDISC_DONT;
>> If you insist on doing this, you need to save the old value and restore
>> it after ip_queue_xmit().
>>
>> The reason is that PMTU discovery change on a specific transport or
>> association should not affect the socket, since there could be multiple
>> associations on a given socket. Each association has it's own control.
>
> Yes but they'll all pass through here so it'll get set to the
> appropriate value.
>
> Cheers,
OK, I see what you mean. Let me run some tests with this patch. I doesn't
look like it will cause any issues, but I'd like to verify.
Thanks
-vlad
next prev parent reply other threads:[~2008-08-02 23:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 9:56 [PATCH] inet6: Fix paramater issue of inet6_csk_xmit Wei Yongjun
2008-08-01 3:48 ` David Miller
2008-08-01 5:17 ` Wei Yongjun
2008-08-01 9:11 ` Herbert Xu
2008-08-01 9:18 ` David Miller
2008-08-01 9:25 ` Herbert Xu
2008-08-01 11:50 ` Herbert Xu
2008-08-01 13:14 ` Herbert Xu
2008-08-01 14:50 ` Vlad Yasevich
2008-08-02 0:30 ` Herbert Xu
2008-08-02 23:26 ` Vlad Yasevich [this message]
2008-08-03 2:01 ` Herbert Xu
2008-08-03 6:56 ` David Miller
2008-08-04 1:03 ` Vlad Yasevich
2008-08-04 1:55 ` Herbert Xu
2008-08-04 2:58 ` Wei Yongjun
2008-08-04 3:05 ` Herbert Xu
2008-08-04 4:16 ` David Miller
2008-08-04 4:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4894ED25.6040200@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).