From: Brice Goglin <brice.goglin@labri.fr>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kaber@trash.net,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 11/31]: net: Implement simple sw TX hashing.
Date: Sun, 03 Aug 2008 14:35:46 +0200 [thread overview]
Message-ID: <4895A622.4080104@labri.fr> (raw)
In-Reply-To: <4895A19B.5090307@inria.fr>
Brice Goglin wrote:
> So I wonder if we shouldn't change all this into:
> 1) simple_tx_hash(skb) returns a big protocol-independent integer (like
> a concatenation or basic xor of IP proto/addr/...). It basically just
> converts the skb header in something flat and proto-independent.
> 2.a) if the device provides select_queue(), we pass this integer to it.
> select_queue() either uses the skb headers if it really wants to hash IP
> or IPv6 precisely, or uses our protocol-independent integer and just
> hash it in a dumb way without caring about the protocol hidden behind it.
> 2.b) if there's no select_queue(), we hash the big integer depending on
> the number of tx queues
>
Or (easier) just export simple_tx_hash() to modules so that drivers can
rely on it to hash protocols that they have no clue about?
Brice
prev parent reply other threads:[~2008-08-03 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 12:16 [PATCH 11/31]: net: Implement simple sw TX hashing David Miller
[not found] ` <20080717.051635.124264554.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-07-17 15:59 ` Andi Kleen
2008-08-03 12:16 ` Brice Goglin
2008-08-03 12:35 ` Brice Goglin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4895A622.4080104@labri.fr \
--to=brice.goglin@labri.fr \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=kaber@trash.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).