* [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()
@ 2008-08-05 9:22 Gui Jianfeng
2008-08-07 3:20 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Gui Jianfeng @ 2008-08-05 9:22 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-kernel
Add (struct sock*) sk parameter for send_ack.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
include/net/request_sock.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/request_sock.h b/include/net/request_sock.h
index 8d6e991..cac811e 100644
--- a/include/net/request_sock.h
+++ b/include/net/request_sock.h
@@ -33,7 +33,7 @@ struct request_sock_ops {
struct kmem_cache *slab;
int (*rtx_syn_ack)(struct sock *sk,
struct request_sock *req);
- void (*send_ack)(struct sk_buff *skb,
+ void (*send_ack)(struct sock *sk, struct sk_buff *skb,
struct request_sock *req);
void (*send_reset)(struct sock *sk,
struct sk_buff *skb);
--
1.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()
2008-08-05 9:22 [PATCH 1/3] Add (struct sock*) sk parameter for send_ack() Gui Jianfeng
@ 2008-08-07 3:20 ` David Miller
2008-08-07 4:43 ` Gui Jianfeng
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2008-08-07 3:20 UTC (permalink / raw)
To: guijianfeng; +Cc: netdev, linux-kernel
From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Date: Tue, 05 Aug 2008 17:22:38 +0800
> Add (struct sock*) sk parameter for send_ack.
>
> Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
This patch by itself breaks the build.
Don't submit patches this way. Every patch applied should
still leave the tree building.
Also, since your OOPS and detailed description only exists
in the "0/3" email, it won't make it into the commit log
history where it belongs.
Considering all of this, I'd say you should fix this as
one big patch with a really nice commit log message.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-08-07 4:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-05 9:22 [PATCH 1/3] Add (struct sock*) sk parameter for send_ack() Gui Jianfeng
2008-08-07 3:20 ` David Miller
2008-08-07 4:43 ` Gui Jianfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).