netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paulius Zaleckas <paulius.zaleckas@teltonika.lt>
To: David Miller <davem@davemloft.net>
Cc: wangchen@cn.fujitsu.com, mingo@elte.hu, viro@ZenIV.linux.org.uk,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net/ipv4/route.c: fix build error
Date: Wed, 06 Aug 2008 16:04:51 +0300	[thread overview]
Message-ID: <4899A173.2050807@teltonika.lt> (raw)
In-Reply-To: <20080731.205132.203087940.davem@davemloft.net>

David Miller wrote:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Fri, 01 Aug 2008 09:40:59 +0800
> 
>> Dave, the build error keeps showing several days.
> 
> I've applied Ingo's patch, thanks.

And after merging this patch:
[PATCH] ipv4_static_sysctl_init() should be under CONFIG_SYSCTL
author	Al Viro <viro@zeniv.linux.org.uk>
	Wed, 30 Jul 2008 10:32:52 +0000 (06:32 -0400)
committer	Al Viro <viro@zeniv.linux.org.uk>
	Fri, 1 Aug 2008 15:25:22 +0000 (11:25 -0400)
commit	a1bc6eb4b499ae67ada9a01660010580b6569403

This function is over ifdef'ed :)

#ifdef CONFIG_SYSCTL
/*
  * We really need to sanitize the damn ipv4 init order, then all
  * this nonsense will go away.
  */
void __init ip_static_sysctl_init(void)
{
#ifdef CONFIG_SYSCTL
	register_sysctl_paths(ipv4_route_path, ipv4_route_table);
#endif
}
#endif

BR,
Paulius Zaleckas

  reply	other threads:[~2008-08-06 13:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080727075933.GB28946@ZenIV.linux.org.uk>
     [not found] ` <20080727.044118.102038262.davem@davemloft.net>
     [not found]   ` <20080727213905.GA4499@elte.hu>
     [not found]     ` <20080727214250.GA5917@elte.hu>
2008-08-01  1:40       ` [PATCH] net/ipv4/route.c: fix build error Wang Chen
2008-08-01  3:51         ` David Miller
2008-08-06 13:04           ` Paulius Zaleckas [this message]
2008-08-07  1:31             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4899A173.2050807@teltonika.lt \
    --to=paulius.zaleckas@teltonika.lt \
    --cc=davem@davemloft.net \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=wangchen@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).