From: Jeff Garzik <jeff@garzik.org>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: csnook@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] atl1: deal with hardware rx checksum bug
Date: Thu, 07 Aug 2008 01:56:21 -0400 [thread overview]
Message-ID: <489A8E85.2080008@garzik.org> (raw)
In-Reply-To: <20080804190510.4029d91d@osprey.hogchain.net>
Jay Cliburn wrote:
> The L1 hardware contains a bug that flags a fragmented IP packet
> as having an incorrect TCP/UDP checksum, even though the packet
> is perfectly valid and its checksum is correct. There's no way to
> distinguish between one of these good packets and a packet that
> actually contains a TCP/UDP checksum error, so all we can do is
> allow the packet to be handed up to the higher layers and let it
> be sorted out there.
>
> Add a comment describing this condition and remove the code that
> currently fails to handle what may or may not be a checksum error.
>
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
> ---
> drivers/net/atlx/atl1.c | 19 +++++++++++--------
applied
prev parent reply other threads:[~2008-08-07 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 0:05 [PATCH] atl1: deal with hardware rx checksum bug Jay Cliburn
2008-08-07 5:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A8E85.2080008@garzik.org \
--to=jeff@garzik.org \
--cc=csnook@redhat.com \
--cc=jacliburn@bellsouth.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).