netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Adrian Bunk <bunk@kernel.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
	Scott Wood <scottwood@freescale.com>,
	Kumar Gala <galak@kernel.crashing.org>,
	netdev@vger.kernel.org,
	"Robert P. J. Day" <rpjday@crashcourse.ca>
Subject: Re: [2.6 patch] remove bogus CONFIG_GFAR_NAPI's
Date: Thu, 07 Aug 2008 02:11:46 -0400	[thread overview]
Message-ID: <489A9222.4020902@garzik.org> (raw)
In-Reply-To: <20080804085936.GB6088@cs181140183.pp.htv.fi>

Adrian Bunk wrote:
> The commit that made the CONFIG_GFAR_NAPI code unconditional was 
> included at the same time as a new CONFIG_GFAR_NAPI user, resulting
> in these bugus #ifdef's.
> 
> Reported-by: Robert P. J. Day <rpjday@crashcourse.ca>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> ---
> 
>  drivers/net/gianfar.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> f30b77c42e33dee1d469a1f1fd0fcfd9cdc26761 
> diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c
> index b8394cf..ca6cf6e 100644
> --- a/drivers/net/gianfar.c
> +++ b/drivers/net/gianfar.c
> @@ -414,9 +414,7 @@ static int gfar_suspend(struct platform_device *pdev, pm_message_t state)
>  		spin_unlock(&priv->rxlock);
>  		spin_unlock_irqrestore(&priv->txlock, flags);
>  
> -#ifdef CONFIG_GFAR_NAPI
>  		napi_disable(&priv->napi);
> -#endif
>  
>  		if (magic_packet) {
>  			/* Enable interrupt on Magic Packet */
> @@ -469,9 +467,7 @@ static int gfar_resume(struct platform_device *pdev)
>  
>  	netif_device_attach(dev);
>  
> -#ifdef CONFIG_GFAR_NAPI
>  	napi_enable(&priv->napi);
> -#endif
>  
>  	return 0;

applied



      reply	other threads:[~2008-08-07  6:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04  8:59 [2.6 patch] remove bogus CONFIG_GFAR_NAPI's Adrian Bunk
2008-08-07  6:11 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489A9222.4020902@garzik.org \
    --to=jeff@garzik.org \
    --cc=bunk@kernel.org \
    --cc=galak@kernel.crashing.org \
    --cc=netdev@vger.kernel.org \
    --cc=romieu@fr.zoreil.com \
    --cc=rpjday@crashcourse.ca \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).