From: Jeff Garzik <jeff@garzik.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open()
Date: Thu, 07 Aug 2008 02:12:13 -0400 [thread overview]
Message-ID: <489A923D.4080302@garzik.org> (raw)
In-Reply-To: <1217536615-2090-1-git-send-email-ehabkost@redhat.com>
Eduardo Habkost wrote:
> xen-netfront never called netif_start_queue() and was was waking the
> queue on xennet_open(), triggering the BUG_ON() on __netif_schedule().
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> drivers/net/xen-netfront.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 902bbe7..c749bdb 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
> }
> spin_unlock_bh(&np->rx_lock);
>
> - xennet_maybe_wake_tx(dev);
> + netif_start_queue(dev);
>
applied
prev parent reply other threads:[~2008-08-07 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 20:36 [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open() Eduardo Habkost
2008-08-07 6:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A923D.4080302@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=ehabkost@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).