* [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open()
@ 2008-07-31 20:36 Eduardo Habkost
2008-08-07 6:12 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Eduardo Habkost @ 2008-07-31 20:36 UTC (permalink / raw)
To: Jeff Garzik, David Miller
Cc: linux-kernel, netdev, Jeremy Fitzhardinge, Eduardo Habkost
xen-netfront never called netif_start_queue() and was was waking the
queue on xennet_open(), triggering the BUG_ON() on __netif_schedule().
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
drivers/net/xen-netfront.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 902bbe7..c749bdb 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
}
spin_unlock_bh(&np->rx_lock);
- xennet_maybe_wake_tx(dev);
+ netif_start_queue(dev);
return 0;
}
--
1.5.5.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open()
2008-07-31 20:36 [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open() Eduardo Habkost
@ 2008-08-07 6:12 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-08-07 6:12 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: David Miller, linux-kernel, netdev, Jeremy Fitzhardinge
Eduardo Habkost wrote:
> xen-netfront never called netif_start_queue() and was was waking the
> queue on xennet_open(), triggering the BUG_ON() on __netif_schedule().
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> drivers/net/xen-netfront.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
> index 902bbe7..c749bdb 100644
> --- a/drivers/net/xen-netfront.c
> +++ b/drivers/net/xen-netfront.c
> @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev)
> }
> spin_unlock_bh(&np->rx_lock);
>
> - xennet_maybe_wake_tx(dev);
> + netif_start_queue(dev);
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-07 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-31 20:36 [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open() Eduardo Habkost
2008-08-07 6:12 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).