From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH][resend] xen-netfront: use netif_start_queue() on xennet_open() Date: Thu, 07 Aug 2008 02:12:13 -0400 Message-ID: <489A923D.4080302@garzik.org> References: <1217536615-2090-1-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jeremy Fitzhardinge To: Eduardo Habkost Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:47935 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754113AbYHGGMT (ORCPT ); Thu, 7 Aug 2008 02:12:19 -0400 In-Reply-To: <1217536615-2090-1-git-send-email-ehabkost@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Eduardo Habkost wrote: > xen-netfront never called netif_start_queue() and was was waking the > queue on xennet_open(), triggering the BUG_ON() on __netif_schedule(). > > Signed-off-by: Eduardo Habkost > --- > drivers/net/xen-netfront.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c > index 902bbe7..c749bdb 100644 > --- a/drivers/net/xen-netfront.c > +++ b/drivers/net/xen-netfront.c > @@ -329,7 +329,7 @@ static int xennet_open(struct net_device *dev) > } > spin_unlock_bh(&np->rx_lock); > > - xennet_maybe_wake_tx(dev); > + netif_start_queue(dev); > applied