From: Jeff Garzik <jgarzik@pobox.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] METH: fix MAC address setup
Date: Thu, 07 Aug 2008 02:12:21 -0400 [thread overview]
Message-ID: <489A9245.4070105@pobox.com> (raw)
In-Reply-To: <20080730231424.CD5E8DEBB8@solo.franken.de>
Thomas Bogendoerfer wrote:
> Setup of the mac filter lost the upper 16bit of the mac address. This
> bug got unconvered by a patch, which fixed the promiscous handling.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
>
> drivers/net/meth.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/meth.c b/drivers/net/meth.c
> index 4cb364e..0a97c26 100644
> --- a/drivers/net/meth.c
> +++ b/drivers/net/meth.c
> @@ -100,7 +100,7 @@ static inline void load_eaddr(struct net_device *dev)
> DPRINTK("Loading MAC Address: %s\n", print_mac(mac, dev->dev_addr));
> macaddr = 0;
> for (i = 0; i < 6; i++)
> - macaddr |= dev->dev_addr[i] << ((5 - i) * 8);
> + macaddr |= (u64)dev->dev_addr[i] << ((5 - i) * 8);
applied
prev parent reply other threads:[~2008-08-07 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 23:14 [PATCH] METH: fix MAC address setup Thomas Bogendoerfer
2008-08-07 6:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A9245.4070105@pobox.com \
--to=jgarzik@pobox.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).