netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, eugeneteo@kernel.sg, alan@redhat.com,
	eteo@redhat.com
Subject: Re: [patch 06/12] hamradio: add missing sanity check to tty operation
Date: Thu, 07 Aug 2008 02:23:54 -0400	[thread overview]
Message-ID: <489A94FA.3000808@garzik.org> (raw)
In-Reply-To: <200807301938.m6UJcxbO012515@imap1.linux-foundation.org>

akpm@linux-foundation.org wrote:
> From: Eugene Teo <eugeneteo@kernel.sg>
> 
> Add missing sanity check to tty operation.
> 
> Acked-by: Alan Cox <alan@redhat.com>
> Signed-off-by: Eugene Teo <eteo@redhat.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/net/hamradio/mkiss.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation drivers/net/hamradio/mkiss.c
> --- a/drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation
> +++ a/drivers/net/hamradio/mkiss.c
> @@ -548,7 +548,7 @@ static int ax_xmit(struct sk_buff *skb, 
>  		}
>  
>  		printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name,
> -		       (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ?
> +		       (tty_chars_in_buffer(ax->tty) || ax->xleft) ?
>  		       "bad line quality" : "driver error");
>  
>  		ax->xleft = 0;

applied



      reply	other threads:[~2008-08-07  6:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-30 19:38 [patch 06/12] hamradio: add missing sanity check to tty operation akpm
2008-08-07  6:23 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489A94FA.3000808@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@redhat.com \
    --cc=eteo@redhat.com \
    --cc=eugeneteo@kernel.sg \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).