* [patch 06/12] hamradio: add missing sanity check to tty operation
@ 2008-07-30 19:38 akpm
2008-08-07 6:23 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2008-07-30 19:38 UTC (permalink / raw)
To: jeff; +Cc: netdev, akpm, eugeneteo, alan, eteo
From: Eugene Teo <eugeneteo@kernel.sg>
Add missing sanity check to tty operation.
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Eugene Teo <eteo@redhat.com>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/net/hamradio/mkiss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation drivers/net/hamradio/mkiss.c
--- a/drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation
+++ a/drivers/net/hamradio/mkiss.c
@@ -548,7 +548,7 @@ static int ax_xmit(struct sk_buff *skb,
}
printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name,
- (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ?
+ (tty_chars_in_buffer(ax->tty) || ax->xleft) ?
"bad line quality" : "driver error");
ax->xleft = 0;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 06/12] hamradio: add missing sanity check to tty operation
2008-07-30 19:38 [patch 06/12] hamradio: add missing sanity check to tty operation akpm
@ 2008-08-07 6:23 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-08-07 6:23 UTC (permalink / raw)
To: akpm; +Cc: netdev, eugeneteo, alan, eteo
akpm@linux-foundation.org wrote:
> From: Eugene Teo <eugeneteo@kernel.sg>
>
> Add missing sanity check to tty operation.
>
> Acked-by: Alan Cox <alan@redhat.com>
> Signed-off-by: Eugene Teo <eteo@redhat.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/hamradio/mkiss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation drivers/net/hamradio/mkiss.c
> --- a/drivers/net/hamradio/mkiss.c~hamradio-add-missing-sanity-check-to-tty-operation
> +++ a/drivers/net/hamradio/mkiss.c
> @@ -548,7 +548,7 @@ static int ax_xmit(struct sk_buff *skb,
> }
>
> printk(KERN_ERR "mkiss: %s: transmit timed out, %s?\n", dev->name,
> - (ax->tty->ops->chars_in_buffer(ax->tty) || ax->xleft) ?
> + (tty_chars_in_buffer(ax->tty) || ax->xleft) ?
> "bad line quality" : "driver error");
>
> ax->xleft = 0;
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-07 6:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-30 19:38 [patch 06/12] hamradio: add missing sanity check to tty operation akpm
2008-08-07 6:23 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).