From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org
Subject: Re: [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic_hw.c: fix printk warnings
Date: Thu, 07 Aug 2008 02:24:02 -0400 [thread overview]
Message-ID: <489A9502.2020601@garzik.org> (raw)
In-Reply-To: <200807301950.m6UJoDY4013256@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_read_direct':
> drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
> drivers/net/netxen/netxen_nic_hw.c: In function 'netxen_nic_pci_mem_write_direct':
> drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
>
> You don't know what type was used for u64 hence they cannot be printed without
> casting.
>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/netxen/netxen_nic_hw.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff -puN drivers/net/netxen/netxen_nic_hw.c~drivers-net-netxen-netxen_nic_hwc-fix-printk-warnings drivers/net/netxen/netxen_nic_hw.c
> --- a/drivers/net/netxen/netxen_nic_hw.c~drivers-net-netxen-netxen_nic_hwc-fix-printk-warnings
> +++ a/drivers/net/netxen/netxen_nic_hw.c
> @@ -1411,7 +1411,8 @@ static int netxen_nic_pci_mem_read_direc
> (netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
> write_unlock_irqrestore(&adapter->adapter_lock, flags);
> printk(KERN_ERR "%s out of bound pci memory access. "
> - "offset is 0x%llx\n", netxen_nic_driver_name, off);
> + "offset is 0x%llx\n", netxen_nic_driver_name,
> + (unsigned long long)off);
> return -1;
> }
>
> @@ -1484,7 +1485,8 @@ netxen_nic_pci_mem_write_direct(struct n
> (netxen_nic_pci_is_same_window(adapter, off+size-1) == 0)) {
> write_unlock_irqrestore(&adapter->adapter_lock, flags);
> printk(KERN_ERR "%s out of bound pci memory access. "
> - "offset is 0x%llx\n", netxen_nic_driver_name, off);
> + "offset is 0x%llx\n", netxen_nic_driver_name,
> + (unsigned long long)off);
> return -1;
> }
>
> _
applied
prev parent reply other threads:[~2008-08-07 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:50 [patch for 2.6.27? 2/2] drivers/net/netxen/netxen_nic_hw.c: fix printk warnings akpm
2008-08-01 6:19 ` Simon Horman
2008-08-01 6:28 ` Andrew Morton
2008-08-01 6:55 ` David Miller
2008-08-01 7:01 ` Andrew Morton
2008-08-07 6:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A9502.2020601@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).