From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, ben.collins@canonical.com,
david-b@pacbell.net, gregkh@suse.de, stefan.bader@canonical.com
Subject: Re: [patch 09/12] pegasus: add blacklist support to fix Belkin bluetooth dongle.
Date: Thu, 07 Aug 2008 02:24:09 -0400 [thread overview]
Message-ID: <489A9509.90306@garzik.org> (raw)
In-Reply-To: <200807301939.m6UJd2PA012599@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Ben Collins <ben.collins@canonical.com>
>
> Reference: https://launchpad.net/bugs/140511
>
> The Belkin bluetooth dongle unfortunately shares the vendor and device id
> with the network adapter which causes lockups whenever the bluetooth
> dongle is inserted.
>
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> Signed-off-by: Ben Collins <ben.collins@canonical.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
> Cc: David Brownell <david-b@pacbell.net>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/usb/pegasus.c | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff -puN drivers/net/usb/pegasus.c~pegasus-add-blacklist-support-to-fix-belkin-bluetooth-dongle drivers/net/usb/pegasus.c
> --- a/drivers/net/usb/pegasus.c~pegasus-add-blacklist-support-to-fix-belkin-bluetooth-dongle
> +++ a/drivers/net/usb/pegasus.c
> @@ -1285,6 +1285,21 @@ static void check_carrier(struct work_st
> }
> }
>
> +static int pegasus_blacklisted(struct usb_device *udev)
> +{
> + struct usb_device_descriptor *udd = &udev->descriptor;
> +
> + /* Special quirk to keep the driver from handling the Belkin Bluetooth
> + * dongle which happens to have the same ID.
> + */
> + if ((udd->idVendor == VENDOR_BELKIN && udd->idProduct == 0x0121) &&
> + (udd->bDeviceClass == USB_CLASS_WIRELESS_CONTROLLER) &&
> + (udd->bDeviceProtocol == 1))
> + return 1;
> +
> + return 0;
> +}
> +
> static int pegasus_probe(struct usb_interface *intf,
> const struct usb_device_id *id)
> {
> @@ -1296,6 +1311,12 @@ static int pegasus_probe(struct usb_inte
> DECLARE_MAC_BUF(mac);
>
> usb_get_dev(dev);
> +
> + if (pegasus_blacklisted(dev)) {
> + res = -ENODEV;
> + goto out;
> + }
> +
applied
prev parent reply other threads:[~2008-08-07 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 19:39 [patch 09/12] pegasus: add blacklist support to fix Belkin bluetooth dongle akpm
2008-08-07 6:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A9509.90306@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=ben.collins@canonical.com \
--cc=david-b@pacbell.net \
--cc=gregkh@suse.de \
--cc=netdev@vger.kernel.org \
--cc=stefan.bader@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).