From: Jeff Garzik <jgarzik@pobox.com>
To: Brandon Philips <brandon@ifup.org>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [RFC] ethtool: Expand ethtool_cmd.speed to 32 bits
Date: Thu, 07 Aug 2008 02:24:18 -0400 [thread overview]
Message-ID: <489A9512.5090805@pobox.com> (raw)
In-Reply-To: <20080715091841.GA6553@potty.ifup.org>
Brandon Philips wrote:
> Introduce the speed_hi field to ethtool_cmd, using the reserved space,
> to expand the speed field to 2^32 Megabits/second.
>
> Making this field expansion now gives us plenty of time to fix up the
> user-space pieces that use SIOCETHTOOL before hardware faster than 64
> Gb/s is available.
>
> Signed-off-by: Brandon Philips <bphilips@suse.de>
>
> ---
> include/linux/ethtool.h | 17 ++++++++++++++++-
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/include/linux/ethtool.h
> ===================================================================
> --- linux-2.6.orig/include/linux/ethtool.h
> +++ linux-2.6/include/linux/ethtool.h
> @@ -27,9 +27,24 @@ struct ethtool_cmd {
> __u8 autoneg; /* Enable or disable autonegotiation */
> __u32 maxtxpkt; /* Tx pkts before generating tx int */
> __u32 maxrxpkt; /* Rx pkts before generating rx int */
> - __u32 reserved[4];
> + __u16 speed_hi;
> + __u16 reserved2;
> + __u32 reserved[3];
> };
>
> +static inline void ethtool_cmd_speed_set(struct ethtool_cmd *ep,
> + __u32 speed)
> +{
> +
> + ep->speed = (__u16)speed;
> + ep->speed_hi = (__u16)(speed >> 16);
> +}
> +
> +static inline __u32 ethtool_cmd_speed(struct ethtool_cmd *ep)
> +{
> + return (ep->speed_hi << 16) | ep->speed;
> +}
> +
applied
prev parent reply other threads:[~2008-08-07 6:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 9:18 [RFC] ethtool: Expand ethtool_cmd.speed to 32 bits Brandon Philips
2008-07-15 21:53 ` Rick Jones
2008-07-15 22:27 ` David Miller
2008-07-16 6:47 ` Brandon Philips
2008-07-15 22:43 ` David Miller
2008-07-28 17:11 ` Brandon Philips
2008-07-28 18:36 ` Jeff Garzik
2008-08-07 6:24 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489A9512.5090805@pobox.com \
--to=jgarzik@pobox.com \
--cc=brandon@ifup.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).