From: Brice Goglin <brice@myri.com>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: Jeff Garzik <jeff@garzik.org>, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] myri10ge: use ioremap_wc
Date: Sun, 10 Aug 2008 13:59:31 +0200 [thread overview]
Message-ID: <489ED823.6000005@myri.com> (raw)
In-Reply-To: <20080810112500.GA8060@deprecation.cyrius.com>
Martin Michlmayr wrote:
> * Brice Goglin <brice@myri.com> [2008-07-21 10:26]:
>
>> Switch to ioremap_wc(). We keep the MTRR code since ioremap_wc()
>> will use UC_MINUS when falling back to uncachable, and thus let
>> the MTRR WC take precedence.
>>
>
> This change leads to a compilation failure on (at least) arm:
>
> CC [M] drivers/net/myri10ge/myri10ge.o
> drivers/net/myri10ge/myri10ge.c: In function ‘myri10ge_probe’:
> drivers/net/myri10ge/myri10ge.c:3725: error: implicit declaration of function ‘ioremap_wc’
> drivers/net/myri10ge/myri10ge.c:3725: warning: assignment makes pointer from integer without a cast
> make[3]: *** [drivers/net/myri10ge/myri10ge.o] Error 1
>
Isn't arm's asm/io.h supposed to get
#ifndef ARCH_HAS_IOREMAP_WC
#define ioremap_wc ioremap_nocache
#endif
from asm-generic/iomap.h since ARCH_HAS_IOREMAP_WC isn't defined on arm ?
Brice
next prev parent reply other threads:[~2008-08-10 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 8:25 [PATCH 0/2] myri10ge update for 2.6.27 Brice Goglin
2008-07-21 8:25 ` [PATCH 1/2] myri10ge: remove wcfifo Brice Goglin
2008-07-21 8:26 ` [PATCH 2/2] myri10ge: use ioremap_wc Brice Goglin
2008-07-22 20:09 ` Jeff Garzik
2008-08-10 11:25 ` Martin Michlmayr
2008-08-10 11:59 ` Brice Goglin [this message]
2008-08-10 12:38 ` Martin Michlmayr
2008-08-11 9:09 ` Russell King - ARM Linux
2008-08-12 9:14 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489ED823.6000005@myri.com \
--to=brice@myri.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).