* Re: linux-next: Tree for August 6 (8390 et al) [not found] <20080806182828.6bfe0a16.sfr@canb.auug.org.au> @ 2008-08-07 0:21 ` Randy Dunlap 2008-08-07 7:20 ` Geert Uytterhoeven 0 siblings, 1 reply; 7+ messages in thread From: Randy Dunlap @ 2008-08-07 0:21 UTC (permalink / raw) To: Stephen Rothwell; +Cc: linux-next, LKML, netdev One randconfig ends with: drivers/built-in.o: In function `wd_probe1': wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init' make[1]: *** [.tmp_vmlinux1] Error 1 and another one ends with: ERROR: "ei_close" [drivers/net/hp-plus.ko] undefined! ERROR: "ei_open" [drivers/net/hp-plus.ko] undefined! ERROR: "ei_interrupt" [drivers/net/hp-plus.ko] undefined! ERROR: "__alloc_ei_netdev" [drivers/net/hp-plus.ko] undefined! make[2]: *** [__modpost] Error 1 --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Tree for August 6 (8390 et al) 2008-08-07 0:21 ` linux-next: Tree for August 6 (8390 et al) Randy Dunlap @ 2008-08-07 7:20 ` Geert Uytterhoeven 2008-08-07 9:29 ` Alan Cox 0 siblings, 1 reply; 7+ messages in thread From: Geert Uytterhoeven @ 2008-08-07 7:20 UTC (permalink / raw) To: Randy Dunlap; +Cc: Stephen Rothwell, linux-next, LKML, netdev On Wed, 6 Aug 2008, Randy Dunlap wrote: > One randconfig ends with: > > drivers/built-in.o: In function `wd_probe1': > wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init' > make[1]: *** [.tmp_vmlinux1] Error 1 drivers/net/Makefile has: obj-$(CONFIG_WD80x3) += wd.o 8390.o So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3) should link with 8390p.o. Don't know which is the appropriate change here (my gut feeling says the latter). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: linux-next: Tree for August 6 (8390 et al) 2008-08-07 7:20 ` Geert Uytterhoeven @ 2008-08-07 9:29 ` Alan Cox 2008-08-11 9:11 ` [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' Ingo Molnar 0 siblings, 1 reply; 7+ messages in thread From: Alan Cox @ 2008-08-07 9:29 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Randy Dunlap, Stephen Rothwell, linux-next, LKML, netdev On Thu, 7 Aug 2008 09:20:07 +0200 (CEST) Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Wed, 6 Aug 2008, Randy Dunlap wrote: > > One randconfig ends with: > > > > drivers/built-in.o: In function `wd_probe1': > > wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init' > > make[1]: *** [.tmp_vmlinux1] Error 1 > > drivers/net/Makefile has: > > obj-$(CONFIG_WD80x3) += wd.o 8390.o > > So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3) > should link with 8390p.o. Don't know which is the appropriate change > here (my gut feeling says the latter). Safest is the latter. The shared memory interface on the wd is full speed 8 or 16bit (depending on card/jumpers) but I'm not clear about the NIC. Most of the performance hit is on the packet transfer which is private methods on this device so using 8390p won't make a big difference on this board anyway. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' 2008-08-07 9:29 ` Alan Cox @ 2008-08-11 9:11 ` Ingo Molnar 2008-08-11 9:47 ` Jeff Garzik 0 siblings, 1 reply; 7+ messages in thread From: Ingo Molnar @ 2008-08-11 9:11 UTC (permalink / raw) To: Alan Cox Cc: Geert Uytterhoeven, Randy Dunlap, Stephen Rothwell, linux-next, LKML, netdev, Jeff Garzik * Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > On Thu, 7 Aug 2008 09:20:07 +0200 (CEST) > Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Wed, 6 Aug 2008, Randy Dunlap wrote: > > > One randconfig ends with: > > > > > > drivers/built-in.o: In function `wd_probe1': > > > wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init' > > > make[1]: *** [.tmp_vmlinux1] Error 1 > > > > drivers/net/Makefile has: > > > > obj-$(CONFIG_WD80x3) += wd.o 8390.o > > > > So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3) > > should link with 8390p.o. Don't know which is the appropriate change > > here (my gut feeling says the latter). > > Safest is the latter. The shared memory interface on the wd is full > speed 8 or 16bit (depending on card/jumpers) but I'm not clear about > the NIC. Most of the performance hit is on the packet transfer which > is private methods on this device so using 8390p won't make a big > difference on this board anyway. Alan, Jeff, i triggered this too with latest -git, please pick up the fix below if you dont have it already. Ingo ------------------> >From c03cb1727bb4c5433436bfb0fab59fdcc00749c3 Mon Sep 17 00:00:00 2001 From: Ingo Molnar <mingo@elte.hu> Date: Mon, 11 Aug 2008 11:11:42 +0200 Subject: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' fix: drivers/built-in.o: In function `wd_probe1': wd.c:(.init.text+0xb247): undefined reference to `NS8390p_init' that triggers with: http://redhat.com/~mingo/misc/config-Mon_Aug_11_10_40_46_CEST_2008.bad Signed-off-by: Ingo Molnar <mingo@elte.hu> --- drivers/net/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/Makefile b/drivers/net/Makefile index 7629c90..dc6dbf6 100644 --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -106,7 +106,7 @@ ifeq ($(CONFIG_FEC_MPC52xx_MDIO),y) obj-$(CONFIG_FEC_MPC52xx) += fec_mpc52xx_phy.o endif obj-$(CONFIG_68360_ENET) += 68360enet.o -obj-$(CONFIG_WD80x3) += wd.o 8390.o +obj-$(CONFIG_WD80x3) += wd.o 8390p.o obj-$(CONFIG_EL2) += 3c503.o 8390p.o obj-$(CONFIG_NE2000) += ne.o 8390p.o obj-$(CONFIG_NE2_MCA) += ne2.o 8390p.o ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' 2008-08-11 9:11 ` [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' Ingo Molnar @ 2008-08-11 9:47 ` Jeff Garzik 2008-08-11 11:11 ` Ingo Molnar 2008-08-11 20:51 ` David Miller 0 siblings, 2 replies; 7+ messages in thread From: Jeff Garzik @ 2008-08-11 9:47 UTC (permalink / raw) To: Ingo Molnar Cc: Alan Cox, Geert Uytterhoeven, Randy Dunlap, Stephen Rothwell, linux-next, LKML, netdev Ingo Molnar wrote: > * Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > >> On Thu, 7 Aug 2008 09:20:07 +0200 (CEST) >> Geert Uytterhoeven <geert@linux-m68k.org> wrote: >> >>> On Wed, 6 Aug 2008, Randy Dunlap wrote: >>>> One randconfig ends with: >>>> >>>> drivers/built-in.o: In function `wd_probe1': >>>> wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init' >>>> make[1]: *** [.tmp_vmlinux1] Error 1 >>> drivers/net/Makefile has: >>> >>> obj-$(CONFIG_WD80x3) += wd.o 8390.o >>> >>> So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3) >>> should link with 8390p.o. Don't know which is the appropriate change >>> here (my gut feeling says the latter). >> Safest is the latter. The shared memory interface on the wd is full >> speed 8 or 16bit (depending on card/jumpers) but I'm not clear about >> the NIC. Most of the performance hit is on the packet transfer which >> is private methods on this device so using 8390p won't make a big >> difference on this board anyway. > > Alan, Jeff, i triggered this too with latest -git, please pick up the > fix below if you dont have it already. > > Ingo > > ------------------> >>From c03cb1727bb4c5433436bfb0fab59fdcc00749c3 Mon Sep 17 00:00:00 2001 > From: Ingo Molnar <mingo@elte.hu> > Date: Mon, 11 Aug 2008 11:11:42 +0200 > Subject: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' > > fix: > > drivers/built-in.o: In function `wd_probe1': > wd.c:(.init.text+0xb247): undefined reference to `NS8390p_init' > > that triggers with: > > http://redhat.com/~mingo/misc/config-Mon_Aug_11_10_40_46_CEST_2008.bad > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > drivers/net/Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) DaveM should have it AFAIK, I'll double-check and make sure it got in somewhere. Jeff ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' 2008-08-11 9:47 ` Jeff Garzik @ 2008-08-11 11:11 ` Ingo Molnar 2008-08-11 20:51 ` David Miller 1 sibling, 0 replies; 7+ messages in thread From: Ingo Molnar @ 2008-08-11 11:11 UTC (permalink / raw) To: Jeff Garzik Cc: Alan Cox, Geert Uytterhoeven, Randy Dunlap, Stephen Rothwell, linux-next, LKML, netdev * Jeff Garzik <jgarzik@pobox.com> wrote: > Ingo Molnar wrote: >> * Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: >> >>> On Thu, 7 Aug 2008 09:20:07 +0200 (CEST) >>> Geert Uytterhoeven <geert@linux-m68k.org> wrote: >>> >>>> On Wed, 6 Aug 2008, Randy Dunlap wrote: >>>>> One randconfig ends with: >>>>> >>>>> drivers/built-in.o: In function `wd_probe1': >>>>> wd.c:(.init.text+0x6179): undefined reference to `NS8390p_init' >>>>> make[1]: *** [.tmp_vmlinux1] Error 1 >>>> drivers/net/Makefile has: >>>> >>>> obj-$(CONFIG_WD80x3) += wd.o 8390.o >>>> >>>> So either wd_probe1() should call NS8390_init(), or obj-$(CONFIG_WD80x3) >>>> should link with 8390p.o. Don't know which is the appropriate change >>>> here (my gut feeling says the latter). >>> Safest is the latter. The shared memory interface on the wd is full >>> speed 8 or 16bit (depending on card/jumpers) but I'm not clear about >>> the NIC. Most of the performance hit is on the packet transfer which >>> is private methods on this device so using 8390p won't make a big >>> difference on this board anyway. >> >> Alan, Jeff, i triggered this too with latest -git, please pick up the >> fix below if you dont have it already. >> >> Ingo >> >> ------------------> >>> From c03cb1727bb4c5433436bfb0fab59fdcc00749c3 Mon Sep 17 00:00:00 2001 >> From: Ingo Molnar <mingo@elte.hu> >> Date: Mon, 11 Aug 2008 11:11:42 +0200 >> Subject: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' >> >> fix: >> >> drivers/built-in.o: In function `wd_probe1': >> wd.c:(.init.text+0xb247): undefined reference to `NS8390p_init' >> >> that triggers with: >> >> http://redhat.com/~mingo/misc/config-Mon_Aug_11_10_40_46_CEST_2008.bad >> >> Signed-off-by: Ingo Molnar <mingo@elte.hu> >> --- >> drivers/net/Makefile | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > DaveM should have it AFAIK, I'll double-check and make sure it got in > somewhere. there's also this build failure: wd.c:(.text+0x38804): undefined reference to `ei_close' wd.c:(.text+0x38882): undefined reference to `ei_open' wd.c:(.init.text+0x4952): undefined reference to `ei_interrupt' wd.c:(.init.text+0x4c27): undefined reference to `ei_poll' (.init.text+0x4c83): undefined reference to `__alloc_ei_netdev' which are only defined in 8390.c. Ingo ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' 2008-08-11 9:47 ` Jeff Garzik 2008-08-11 11:11 ` Ingo Molnar @ 2008-08-11 20:51 ` David Miller 1 sibling, 0 replies; 7+ messages in thread From: David Miller @ 2008-08-11 20:51 UTC (permalink / raw) To: jgarzik Cc: mingo, alan, geert, randy.dunlap, sfr, linux-next, linux-kernel, netdev From: Jeff Garzik <jgarzik@pobox.com> Date: Mon, 11 Aug 2008 05:47:33 -0400 > DaveM should have it AFAIK, I'll double-check and make sure it got in > somewhere. I pushed your most recent merge of driver fixes to Linus so if it's not in his tree I haven't seen it yet. :-) ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2008-08-11 20:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20080806182828.6bfe0a16.sfr@canb.auug.org.au>
2008-08-07 0:21 ` linux-next: Tree for August 6 (8390 et al) Randy Dunlap
2008-08-07 7:20 ` Geert Uytterhoeven
2008-08-07 9:29 ` Alan Cox
2008-08-11 9:11 ` [PATCH] net, wd.c: fix undefined reference to `NS8390p_init' Ingo Molnar
2008-08-11 9:47 ` Jeff Garzik
2008-08-11 11:11 ` Ingo Molnar
2008-08-11 20:51 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).