From: Brian Haley <brian.haley@hp.com>
To: Eugene Teo <eugeneteo@kernel.sg>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
John Gumb <john.gumb@tandberg.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: OOPS, ip -f inet6 route get fec0::1, linux-2.6.26, ip6_route_output, rt6_fill_node+0x175
Date: Mon, 11 Aug 2008 20:41:22 -0400 [thread overview]
Message-ID: <48A0DC32.9030309@hp.com> (raw)
In-Reply-To: <20080811110335.GA29407@kernel.sg>
Eugene Teo wrote:
> I think it's better to use a helper routine like ipv6_get_saddr to make
> sure that both dst and rt6i_idev arguments are checked for NULL.
>
> I have compiled, and tested the patch.
>
> Thanks,
> Eugene
>
> ---
> Fix NULL pointer dereference in rt6_fill_node().
>
> # ip -f inet6 route get fec0::1
>
> BUG: unable to handle kernel NULL pointer dereference at 00000000
> IP: [<c0369b85>] rt6_fill_node+0x175/0x3b0
> EIP is at rt6_fill_node+0x175/0x3b0
>
> Cc: Stable <stable@kernel.org>
> Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Acked-by: Brian Haley <brian.haley@hp.com>
But Yoshfuji might have another opinion since he did the work to remove
ipv6_get_saddr() in the first place.
-Brian
next prev parent reply other threads:[~2008-08-12 0:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9F6ACAE02B6DD040A1E259977622CFDB033590C3@oslexcp1.eu.tandberg.int>
2008-08-07 20:37 ` OOPS, ip -f inet6 route get fec0::1, linux-2.6.26, ip6_route_output, rt6_fill_node+0x175 Alexey Dobriyan
2008-08-08 4:57 ` Brian Haley
2008-08-11 7:41 ` John Gumb
2008-08-11 8:40 ` Eugene Teo
2008-08-11 20:50 ` David Miller
2008-08-12 0:13 ` Eugene Teo
2008-08-12 0:41 ` Eugene Teo
2008-08-12 1:40 ` Eugene Teo
2008-08-11 11:03 ` Eugene Teo
2008-08-12 0:41 ` Brian Haley [this message]
2008-08-12 9:11 ` OOPS, ip -f inet6 route get fec0::1, linux-2.6.26,ip6_route_output, rt6_fill_node+0x175 John Gumb
2008-08-13 9:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A0DC32.9030309@hp.com \
--to=brian.haley@hp.com \
--cc=adobriyan@gmail.com \
--cc=eugeneteo@kernel.sg \
--cc=john.gumb@tandberg.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).