From: Rick Jones <rick.jones2@hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
gallatin@myri.com, netdev@vger.kernel.org, brice@myri.com
Subject: Re: LRO restructuring?
Date: Mon, 11 Aug 2008 18:30:11 -0700 [thread overview]
Message-ID: <48A0E7A3.6030200@hp.com> (raw)
In-Reply-To: <20080812010004.GD18547@gondor.apana.org.au>
Herbert Xu wrote:
> On Mon, Aug 11, 2008 at 05:54:34PM -0700, David Miller wrote:
>
>>And the checksums :-) As an intermediate node we don't want
>>to touch the checksum.
>
>
> Yeah if it wasn't verified then we must store this as well.
Even if it was verified I think you want to keep the checksums from the
header. Since an intermediate device isn't supposed to be peeking at
the TCP part anyway, it wouldn't do to drop the segment ourselves, pass
it along to be dropped by the ultimate reciever. And if there is
something amis in the verification or the regeneration, we don't want to
introduce silent data corruption.
Likely that also goes for the IP header checksum...
rick jones
next prev parent reply other threads:[~2008-08-12 1:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 13:30 LRO restructuring? Andrew Gallatin
2008-08-11 21:03 ` David Miller
2008-08-12 11:50 ` Andrew Gallatin
2008-08-13 2:14 ` Herbert Xu
2008-08-12 0:50 ` Herbert Xu
2008-08-12 0:54 ` David Miller
2008-08-12 1:00 ` Herbert Xu
2008-08-12 1:30 ` Rick Jones [this message]
2008-08-12 1:39 ` David Miller
2008-08-12 1:53 ` Herbert Xu
2009-02-18 19:25 ` James Huang
2009-02-18 19:42 ` Ben Hutchings
2009-02-18 19:46 ` Stephen Hemminger
2009-02-19 13:53 ` Herbert Xu
2009-02-19 22:20 ` James Huang
[not found] ` <f0ed9b110902191417k2917d856q9098b304eeb7435b@mail.gmail.com>
2009-02-20 0:37 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A0E7A3.6030200@hp.com \
--to=rick.jones2@hp.com \
--cc=brice@myri.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).