From: Jeff Garzik <jeff@garzik.org>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.27] myri10ge: myri10ge_fw_name also overrides the rss firmware
Date: Thu, 14 Aug 2008 04:28:53 -0400 [thread overview]
Message-ID: <48A3ECC5.3050006@garzik.org> (raw)
In-Reply-To: <48A33090.2060208@myri.com>
Brice Goglin wrote:
> When myri10ge_fw_name is given, use it to override the rss firmware
> name as well.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
> ---
> drivers/net/myri10ge/myri10ge.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/net/myri10ge/myri10ge.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/myri10ge/myri10ge.c 2008-08-12 16:43:26.000000000 +0200
> +++ linux-2.6/drivers/net/myri10ge/myri10ge.c 2008-08-12 16:43:53.000000000 +0200
> @@ -3548,7 +3548,11 @@
>
> /* try to load the slice aware rss firmware */
> old_fw = mgp->fw_name;
> - if (old_fw == myri10ge_fw_aligned)
> + if (myri10ge_fw_name != NULL) {
> + dev_info(&mgp->pdev->dev, "overriding rss firmware to %s\n",
> + myri10ge_fw_name);
> + mgp->fw_name = myri10ge_fw_name;
> + } else if (old_fw == myri10ge_fw_aligned)
> mgp->fw_name = myri10ge_fw_rss_aligned;
> else
> mgp->fw_name = myri10ge_fw_rss_unaligned;
>
>
> --
applied
prev parent reply other threads:[~2008-08-14 8:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 19:05 [PATCH 2.6.27] myri10ge: myri10ge_fw_name also overrides the rss firmware Brice Goglin
2008-08-14 8:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A3ECC5.3050006@garzik.org \
--to=jeff@garzik.org \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).