From: Jeff Garzik <jeff@garzik.org>
To: roel kluin <roel.kluin@gmail.com>
Cc: jie.yang@atheros.com, jgarzik@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?
Date: Thu, 14 Aug 2008 04:44:46 -0400 [thread overview]
Message-ID: <48A3F07E.8000808@garzik.org> (raw)
In-Reply-To: <489B21CA.7010508@gmail.com>
roel kluin wrote:
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
> struct atl1e_adapter *adapter = netdev_priv(netdev);
>
> if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
> return -EOPNOTSUPP;
> /* these settings will always override what we currently have */
applied
prev parent reply other threads:[~2008-08-14 8:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 16:24 [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? roel kluin
2008-08-08 1:25 ` Jie Yang
2008-08-08 3:12 ` Jie Yang
2008-08-14 8:44 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A3F07E.8000808@garzik.org \
--to=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).